Pretty sure It's the latter.  I don't use MinGW enough enough to know how compatible it is with msvc, but this uses a bunch of COM APIs and funny Microsoftisms like declspec(novtable), declspec(uuid), etc, and the MinGW bot was throwing hundreds of compiler errors.  If there's a way to make it work I'm happy to try<br><div class="gmail_quote"><div dir="ltr">On Thu, Mar 16, 2017 at 8:23 AM Nico Weber <<a href="mailto:thakis@chromium.org">thakis@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Should this be a compile-time thing? I thought in general we try to make clang-built-with-msvc and clang-built-with-mingw behave roughly the same except for a different default triple, i.e. maybe this should be keyed off the triple at runtime instead of with a compile-time ifdef. Or do some of the APIs the 2017 path calls not exist in mingw?</div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Wed, Mar 15, 2017 at 1:09 PM, Zachary Turner via cfe-commits <span dir="ltr" class="gmail_msg"><<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: zturner<br class="gmail_msg">
Date: Wed Mar 15 12:09:36 2017<br class="gmail_msg">
New Revision: 297861<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=297861&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=297861&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Don't use MSVC Setup Api on MinGW.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    cfe/trunk/lib/Driver/ToolChains/MSVC.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: cfe/trunk/lib/Driver/ToolChains/MSVC.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/MSVC.cpp?rev=297861&r1=297860&r2=297861&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/MSVC.cpp?rev=297861&r1=297860&r2=297861&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- cfe/trunk/lib/Driver/ToolChains/MSVC.cpp (original)<br class="gmail_msg">
+++ cfe/trunk/lib/Driver/ToolChains/MSVC.cpp Wed Mar 15 12:09:36 2017<br class="gmail_msg">
@@ -44,6 +44,11 @@<br class="gmail_msg">
     #define NOMINMAX<br class="gmail_msg">
   #endif<br class="gmail_msg">
   #include <windows.h><br class="gmail_msg">
+#endif<br class="gmail_msg">
+<br class="gmail_msg">
+#ifdef _MSC_VER<br class="gmail_msg">
+// Don't support SetupApi on MinGW.<br class="gmail_msg">
+#define USE_MSVC_SETUP_API<br class="gmail_msg">
<br class="gmail_msg">
 // Make sure this comes before MSVCSetupApi.h<br class="gmail_msg">
 #include <comdef.h><br class="gmail_msg">
@@ -170,7 +175,7 @@ static bool findVCToolChainViaEnvironmen<br class="gmail_msg">
 // longer listed in the registry.<br class="gmail_msg">
 static bool findVCToolChainViaSetupConfig(std::string &Path,<br class="gmail_msg">
                                           bool &IsVS2017OrNewer) {<br class="gmail_msg">
-#if !defined(USE_WIN32)<br class="gmail_msg">
+#if !defined(USE_MSVC_SETUP_API)<br class="gmail_msg">
   return false;<br class="gmail_msg">
 #else<br class="gmail_msg">
   // FIXME: This really should be done once in the top-level program's main<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg">
</blockquote></div><br class="gmail_msg"></div>
</blockquote></div>