<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 3/3/17 7:45 PM, Eric Fiselier wrote:<br>
</div>
<blockquote
cite="mid:CAB=TDAWvA1OXP5KZXw6fYrVYTr3ad3TQURBvnoL2DVJdyuQszg@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div dir="ltr">LIBCXXABI_HAS_CXA_THREAD_ATEXIT_IMPL should be set
by `check_library_exists` at the bottom of `config-ix.cmake`.</div>
</blockquote>
Ah, cool.<br>
<br>
<br>
Jon<br>
<br>
<blockquote
cite="mid:CAB=TDAWvA1OXP5KZXw6fYrVYTr3ad3TQURBvnoL2DVJdyuQszg@mail.gmail.com"
type="cite">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Mar 3, 2017 at 7:22 PM,
Jonathan Roelofs <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:jonathan@codesourcery.com" target="_blank">jonathan@codesourcery.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class=""><br>
<br>
On 3/3/17 6:26 PM, Eric Fiselier via cfe-commits wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: ericwf<br>
Date: Fri Mar 3 19:26:41 2017<br>
New Revision: 296940<br>
<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=296940&view=rev"
rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=296940&view=rev</a><br>
Log:<br>
Fix PR25874 - Detect features required for
cxa_thread_atexit_test.pass.cp<wbr>p<br>
<br>
Modified:<br>
libcxxabi/trunk/test/CMakeList<wbr>s.txt<br>
libcxxabi/trunk/test/cxa_threa<wbr>d_atexit_test.pass.cpp<br>
libcxxabi/trunk/test/libcxxabi<wbr>/test/config.py<br>
libcxxabi/trunk/test/<a moz-do-not-send="true"
href="http://lit.site.cfg.in" rel="noreferrer"
target="_blank">lit.site.<wbr>cfg.in</a><br>
<br>
Modified: libcxxabi/trunk/test/CMakeList<wbr>s.txt<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/CMakeLists.txt?rev=296940&r1=296939&r2=296940&view=diff"
rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/libcxxabi/trunk/test/CMa<wbr>keLists.txt?rev=296940&r1=2969<wbr>39&r2=296940&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxxabi/trunk/test/CMakeList<wbr>s.txt (original)<br>
+++ libcxxabi/trunk/test/CMakeList<wbr>s.txt Fri Mar 3
19:26:41 2017<br>
@@ -18,6 +18,7 @@ pythonize_bool(LIBCXXABI_ENABL<wbr>E_THREADS)<br>
pythonize_bool(LIBCXXABI_ENAB<wbr>LE_EXCEPTIONS)<br>
pythonize_bool(LIBCXXABI_USE_<wbr>LLVM_UNWINDER)<br>
pythonize_bool(LIBCXXABI_BUIL<wbr>D_EXTERNAL_THREAD_LIBRARY)<br>
+pythonize_bool(LIBCXXABI_HAS_<wbr>CXA_THREAD_ATEXIT_IMPL)<br>
</blockquote>
<br>
</span>
AFAIU, this is only allows specifying it at build time and
not auto-detection of it. Did you intend on setting this via
something like a CHECK_CXX_SOURCE_COMPILES check?<br>
<br>
<br>
Jon<span class="HOEnZb"><font color="#888888"><br>
<br>
<br>
-- <br>
Jon Roelofs<br>
<a moz-do-not-send="true"
href="mailto:jonathan@codesourcery.com"
target="_blank">jonathan@codesourcery.com</a><br>
CodeSourcery / Mentor Embedded<br>
</font></span></blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Jon Roelofs
<a class="moz-txt-link-abbreviated" href="mailto:jonathan@codesourcery.com">jonathan@codesourcery.com</a>
CodeSourcery / Mentor Embedded</pre>
</body>
</html>