<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 1, 2017 at 10:35 AM, Mehdi Amini <span dir="ltr"><<a href="mailto:mehdi.amini@apple.com" target="_blank">mehdi.amini@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">I’m not sure I find this nice to see this upstream.<div><br></div><div>I not fond in general of this kind of difference in behavior. I don’t think it is good for clang to have different default for this kind of settings depending on the platform. It does not provide a very good user experience from a cross-platform point of view (i.e. my compiler behaves very differently when I target one platform instead of another).</div></div></blockquote><div><br></div><div>What I like about it is that the upstream PS4 bots now test that we don't depend on the C++98 default language standard in tests, which is net positive IMO since it facilitates future changes. Should this be a point of vendor/platform extensibility? That's a question for cfe-dev, but I don't think it's unreasonable. (see also: PS4 has -fno-rtti and -fno-exceptions by default, even though users already know to pass the right flags and expect to have to).</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><br></div><div>— </div><span class="HOEnZb"><font color="#888888"><div>Mehdi</div></font></span><div><div class="h5"><div><br></div><div><br></div><div><br><div><div><blockquote type="cite"><div>On Feb 28, 2017, at 11:22 PM, Sean Silva via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:</div><br class="m_-5147331315984851308Apple-interchange-newline"><div><div dir="ltr">Nice!<div><br></div><div>-- Sean Silva</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 28, 2017 at 5:01 PM, Paul Robinson via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: probinson<br>
Date: Tue Feb 28 19:01:10 2017<br>
New Revision: 296554<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=296554&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=296554&view=rev</a><br>
Log:<br>
[PS4] Set our default dialect to C++11. NFC for other targets.<br>
Reapplies r296209 now that r296549 has fixed what really seems to be<br>
the last problematic test.<br>
<br>
Modified:<br>
cfe/trunk/lib/Frontend/Compile<wbr>rInvocation.cpp<br>
<br>
Modified: cfe/trunk/lib/Frontend/Compile<wbr>rInvocation.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/CompilerInvocation.cpp?rev=296554&r1=296553&r2=296554&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/cfe/trunk/lib/Frontend/<wbr>CompilerInvocation.cpp?rev=<wbr>296554&r1=296553&r2=296554&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/lib/Frontend/Compile<wbr>rInvocation.cpp (original)<br>
+++ cfe/trunk/lib/Frontend/Compile<wbr>rInvocation.cpp Tue Feb 28 19:01:10 2017<br>
@@ -1582,7 +1582,11 @@ void CompilerInvocation::setLangDef<wbr>aults<br>
case IK_PreprocessedCXX:<br>
case IK_ObjCXX:<br>
case IK_PreprocessedObjCXX:<br>
- LangStd = LangStandard::lang_gnucxx98;<br>
+ // The PS4 uses C++11 as the default C++ standard.<br>
+ if (T.isPS4())<br>
+ LangStd = LangStandard::lang_gnucxx11;<br>
+ else<br>
+ LangStd = LangStandard::lang_gnucxx98;<br>
break;<br>
case IK_RenderScript:<br>
LangStd = LangStandard::lang_c99;<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
______________________________<wbr>_________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br></div></blockquote></div><br></div></div></div></div></div></blockquote></div><br></div></div>