<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I’m not sure I find this nice to see this upstream.<div class=""><br class=""></div><div class="">I not fond in general of this kind of difference in behavior. I don’t think it is good for clang to have different default for this kind of settings depending on the platform. It does not provide a very good user experience from a cross-platform point of view (i.e. my compiler behaves very differently when I target one platform instead of another).</div><div class=""><br class=""></div><div class="">— </div><div class="">Mehdi</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""><div class=""><div><blockquote type="cite" class=""><div class="">On Feb 28, 2017, at 11:22 PM, Sean Silva via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Nice!<div class=""><br class=""></div><div class="">-- Sean Silva</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Feb 28, 2017 at 5:01 PM, Paul Robinson via cfe-commits <span dir="ltr" class=""><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: probinson<br class="">
Date: Tue Feb 28 19:01:10 2017<br class="">
New Revision: 296554<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=296554&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=296554&view=rev</a><br class="">
Log:<br class="">
[PS4] Set our default dialect to C++11. NFC for other targets.<br class="">
Reapplies r296209 now that r296549 has fixed what really seems to be<br class="">
the last problematic test.<br class="">
<br class="">
Modified:<br class="">
cfe/trunk/lib/Frontend/<wbr class="">CompilerInvocation.cpp<br class="">
<br class="">
Modified: cfe/trunk/lib/Frontend/<wbr class="">CompilerInvocation.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/CompilerInvocation.cpp?rev=296554&r1=296553&r2=296554&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/cfe/trunk/lib/<wbr class="">Frontend/CompilerInvocation.<wbr class="">cpp?rev=296554&r1=296553&r2=<wbr class="">296554&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- cfe/trunk/lib/Frontend/<wbr class="">CompilerInvocation.cpp (original)<br class="">
+++ cfe/trunk/lib/Frontend/<wbr class="">CompilerInvocation.cpp Tue Feb 28 19:01:10 2017<br class="">
@@ -1582,7 +1582,11 @@ void CompilerInvocation::<wbr class="">setLangDefaults<br class="">
case IK_PreprocessedCXX:<br class="">
case IK_ObjCXX:<br class="">
case IK_PreprocessedObjCXX:<br class="">
- LangStd = LangStandard::lang_gnucxx98;<br class="">
+ // The PS4 uses C++11 as the default C++ standard.<br class="">
+ if (T.isPS4())<br class="">
+ LangStd = LangStandard::lang_gnucxx11;<br class="">
+ else<br class="">
+ LangStd = LangStandard::lang_gnucxx98;<br class="">
break;<br class="">
case IK_RenderScript:<br class="">
LangStd = LangStandard::lang_c99;<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div><br class=""></div>
_______________________________________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits<br class=""></div></blockquote></div><br class=""></div></div></body></html>