<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 1, 2017, at 3:24 PM, Sean Silva <<a href="mailto:chisophugis@gmail.com" class="">chisophugis@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Mar 1, 2017 at 10:35 AM, Mehdi Amini <span dir="ltr" class=""><<a href="mailto:mehdi.amini@apple.com" target="_blank" class="">mehdi.amini@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="">I’m not sure I find this nice to see this upstream.<div class=""><br class=""></div><div class="">I not fond in general of this kind of difference in behavior. I don’t think it is good for clang to have different default for this kind of settings depending on the platform. It does not provide a very good user experience from a cross-platform point of view (i.e. my compiler behaves very differently when I target one platform instead of another).</div></div></blockquote><div class=""><br class=""></div><div class="">What I like about it is that the upstream PS4 bots now test that we don't depend on the C++98 default language standard in tests, which is net positive IMO since it facilitates future changes. Should this be a point of vendor/platform extensibility? That's a question for cfe-dev, but I don't think it's unreasonable. (see also: PS4 has -fno-rtti and -fno-exceptions by default, even though users already know to pass the right flags and expect to have to).</div></div></div></div></div></blockquote><div><br class=""></div><div>I rather have the driver rejecting “unsupported configuration”, requiring the right flags, instead of diverging the default.</div><div><br class=""></div><div>— </div><div>Mehdi</div><div><br class=""></div><div><br class=""></div><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><div class=""><div class="h5"><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""><div class=""><div class=""><blockquote type="cite" class=""><div class="">On Feb 28, 2017, at 11:22 PM, Sean Silva via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>> wrote:</div><br class="m_-5147331315984851308Apple-interchange-newline"><div class=""><div dir="ltr" class="">Nice!<div class=""><br class=""></div><div class="">-- Sean Silva</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Feb 28, 2017 at 5:01 PM, Paul Robinson via cfe-commits <span dir="ltr" class=""><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: probinson<br class="">
Date: Tue Feb 28 19:01:10 2017<br class="">
New Revision: 296554<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=296554&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-pr<wbr class="">oject?rev=296554&view=rev</a><br class="">
Log:<br class="">
[PS4] Set our default dialect to C++11. NFC for other targets.<br class="">
Reapplies r296209 now that r296549 has fixed what really seems to be<br class="">
the last problematic test.<br class="">
<br class="">
Modified:<br class="">
cfe/trunk/lib/Frontend/Compile<wbr class="">rInvocation.cpp<br class="">
<br class="">
Modified: cfe/trunk/lib/Frontend/Compile<wbr class="">rInvocation.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/CompilerInvocation.cpp?rev=296554&r1=296553&r2=296554&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-pr<wbr class="">oject/cfe/trunk/lib/Frontend/<wbr class="">CompilerInvocation.cpp?rev=<wbr class="">296554&r1=296553&r2=296554&<wbr class="">view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- cfe/trunk/lib/Frontend/Compile<wbr class="">rInvocation.cpp (original)<br class="">
+++ cfe/trunk/lib/Frontend/Compile<wbr class="">rInvocation.cpp Tue Feb 28 19:01:10 2017<br class="">
@@ -1582,7 +1582,11 @@ void CompilerInvocation::setLangDef<wbr class="">aults<br class="">
case IK_PreprocessedCXX:<br class="">
case IK_ObjCXX:<br class="">
case IK_PreprocessedObjCXX:<br class="">
- LangStd = LangStandard::lang_gnucxx98;<br class="">
+ // The PS4 uses C++11 as the default C++ standard.<br class="">
+ if (T.isPS4())<br class="">
+ LangStd = LangStandard::lang_gnucxx11;<br class="">
+ else<br class="">
+ LangStd = LangStandard::lang_gnucxx98;<br class="">
break;<br class="">
case IK_RenderScript:<br class="">
LangStd = LangStandard::lang_c99;<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div><br class=""></div>
______________________________<wbr class="">_________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/cfe-commits</a><br class=""></div></blockquote></div><br class=""></div></div></div></div></div></blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></body></html>