<div dir="ltr">I relanded the test in r296408. Since this deletes temp files created by the OS following an unpredictable pattern, exactly specifying the filename to delete isn't possible. Let me know if putting a functional rm on your bots is a problem and then we can see if we can think of something else, but fixing your bots's rm seems easiest to me :-)</div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Feb 25, 2017 at 10:39 AM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@google.com" target="_blank">thakis@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">Can't you just put gnuwin rm on your bot? Our Windows bots are happy with the test, and having to support an rm without wildcard support seems pretty strange. (<a href="Https://is.gd/chromeclang" target="_blank">Https://is.gd/chromeclang</a> -> tools -> gnuwin-6.zip are the executables our bot uses to run llvm tests)</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Feb 24, 2017 8:13 PM, "Yung, Douglas via cfe-commits" <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Nico,<br>
<br>
The test you added is causing a failure on the PS4 Windows bot. The root of the cause is that the Windows version of rm does not accept wildcards unfortunately. To fix make it work on Windows, you likely need to specify exactly what files/directories you want to delete without using a wildcard:<br>
<br>
<a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/6030" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/build<wbr>ers/llvm-clang-lld-x86_64-<wbr>scei-ps4-windows10pro-fast/bui<wbr>lds/6030</a>:<br>
<br>
$ "rm" "C:\Buildbot\Slave\llvm-clang-<wbr>lld-x86_64-scei-ps4-windows10p<wbr>ro-fast\llvm.obj\tools\clang\<wbr>test\Format\Output/*"<br>
# command stderr:<br>
rm: cannot remove `C:\\Buildbot\\Slave\\llvm-cla<wbr>ng-lld-x86_64-scei-ps4-windows<wbr>10pro-fast\\llvm.obj\\tools\\<wbr>clang\\test\\Format\\Output/*'<wbr>: Invalid argument<br>
<br>
<a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/6031" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/build<wbr>ers/llvm-clang-lld-x86_64-<wbr>scei-ps4-windows10pro-fast/bui<wbr>lds/6031</a>:<br>
<br>
$ "rm" "C:\Buildbot\Slave\llvm-clang-<wbr>lld-x86_64-scei-ps4-windows10p<wbr>ro-fast\llvm.obj\tools\clang\<wbr>test\Format\Output/inplace*"<br>
# command stderr:<br>
rm: cannot remove `C:\\Buildbot\\Slave\\llvm-cla<wbr>ng-lld-x86_64-scei-ps4-windows<wbr>10pro-fast\\llvm.obj\\tools\\<wbr>clang\\test\\Format\\Output/<wbr>inplace*': Invalid argument<br>
<br>
Can you fix the test?<br>
<br>
Douglas Yung<br>
<br>
> -----Original Message-----<br>
> From: cfe-commits [mailto:<a href="mailto:cfe-commits-bounces@lists.llvm.org" target="_blank">cfe-commits-bounces@li<wbr>sts.llvm.org</a>] On Behalf Of<br>
> Nico Weber via cfe-commits<br>
> Sent: Friday, February 24, 2017 13:02<br>
> To: <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> Subject: r296171 - Try to unbreak tests after r296166<br>
><br>
> Author: nico<br>
> Date: Fri Feb 24 15:01:43 2017<br>
> New Revision: 296171<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=296171&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=296171&view=rev</a><br>
> Log:<br>
> Try to unbreak tests after r296166<br>
><br>
> Looks like %T isn't per-test but per-test-directory, and the rm was deleting<br>
> temp files written by other tests in test/Format.  Limit the rm's scope a bit.<br>
><br>
> Modified:<br>
>     cfe/trunk/test/Format/<wbr>inplace.cpp<br>
><br>
> Modified: cfe/trunk/test/Format/inplace.<wbr>cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
> project/cfe/trunk/test/Format/<wbr>inplace.cpp?rev=296171&r1=2961<wbr>70&r2=296171&view=<br>
> diff<br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- cfe/trunk/test/Format/inplace.<wbr>cpp (original)<br>
> +++ cfe/trunk/test/Format/inplace.<wbr>cpp Fri Feb 24 15:01:43 2017<br>
> @@ -1,6 +1,6 @@<br>
>  // Regression test to check that clang-format does not leave behind temporary<br>
> // files on Windows when doing in-place formatting.<br>
> -// RUN: rm %T/*<br>
> +// RUN: rm %T/inplace*<br>
>  // RUN: cp %s %T/inplace.cpp<br>
>  // RUN: clang-format -style=LLVM -i %T/inplace.cpp  // RUN: ls %T ><br>
> %T/files.txt<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>
</div></div></blockquote></div><br></div>