<div dir="ltr">That's two votes for "this is too surprising" - changed.<div><br><div><a href="https://imgflip.com/i/1k93rm">https://imgflip.com/i/1k93rm</a><br></div><div><a href="https://68.media.tumblr.com/8db2fe0a6f84ff128157a2b615f519bf/tumblr_inline_nenq4hMoQA1sb080b.gif">https://68.media.tumblr.com/8db2fe0a6f84ff128157a2b615f519bf/tumblr_inline_nenq4hMoQA1sb080b.gif</a><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Feb 24, 2017 at 9:54 AM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><span class=""><div dir="ltr">On Thu, Feb 23, 2017 at 10:40 PM Sam McCall <<a href="mailto:sammccall@google.com" target="_blank">sammccall@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto" class="m_5045187437469104820gmail_msg"><div class="m_5045187437469104820gmail_msg"><br class="m_5045187437469104820gmail_msg"><div class="gmail_extra m_5045187437469104820gmail_msg"><br class="m_5045187437469104820gmail_msg"><div class="gmail_quote m_5045187437469104820gmail_msg">On Feb 23, 2017 8:48 PM, "Haojian Wu via Phabricator" <<a href="mailto:reviews@reviews.llvm.org" class="m_5045187437469104820gmail_msg" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br type="attribution" class="m_5045187437469104820gmail_msg"><blockquote class="m_5045187437469104820m_-864003687959933514quote m_5045187437469104820gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_5045187437469104820m_-864003687959933514quoted-text m_5045187437469104820gmail_msg">hokein added inline comments.<br class="m_5045187437469104820gmail_msg">
<br class="m_5045187437469104820gmail_msg">
<br class="m_5045187437469104820gmail_msg">
================<br class="m_5045187437469104820gmail_msg">
</div>Comment at: unittests/include-fixer/find-<wbr>all-symbols/<wbr>FindAllSymbolsTests.cpp:40<br class="m_5045187437469104820gmail_msg">
+  void reportSymbols(llvm::StringRef FileName,<br class="m_5045187437469104820gmail_msg">
+                     SymbolInfo::SignalMap NewSymbols) override {<br class="m_5045187437469104820gmail_msg">
+    for (const auto &Entry : NewSymbols)<br class="m_5045187437469104820gmail_msg">
----------------<br class="m_5045187437469104820gmail_msg">
A new catch: `NewSymbols` should be passed by reference, otherwise a copy will be generated.<br class="m_5045187437469104820gmail_msg"></blockquote></div></div></div></div><div dir="auto" class="m_5045187437469104820gmail_msg"><div dir="auto" class="m_5045187437469104820gmail_msg">I did actually intend by-value here, FindAllSymbols no longer needs the map once it's reported, so it is moved rather than copied (see the end of FindAllSymbols.cpp)</div><div dir="auto" class="m_5045187437469104820gmail_msg"><br class="m_5045187437469104820gmail_msg"></div><div dir="auto" class="m_5045187437469104820gmail_msg">If this is too surprising, I can change it.</div></div></blockquote><div><br></div></span><div>I'd say that that couples the call site and the function too much.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto" class="m_5045187437469104820gmail_msg"><div dir="auto" class="m_5045187437469104820gmail_msg"><br class="m_5045187437469104820gmail_msg"></div><div dir="auto" class="m_5045187437469104820gmail_msg"><br class="m_5045187437469104820gmail_msg"></div><div dir="auto" class="m_5045187437469104820gmail_msg"><div class="gmail_extra m_5045187437469104820gmail_msg"><div class="gmail_quote m_5045187437469104820gmail_msg"><blockquote class="m_5045187437469104820m_-864003687959933514quote m_5045187437469104820gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="m_5045187437469104820gmail_msg"><br class="m_5045187437469104820gmail_msg">
<br class="m_5045187437469104820gmail_msg">
<a href="https://reviews.llvm.org/D30210" rel="noreferrer" class="m_5045187437469104820gmail_msg" target="_blank">https://reviews.llvm.org/<wbr>D30210</a><br class="m_5045187437469104820gmail_msg">
<br class="m_5045187437469104820gmail_msg">
<br class="m_5045187437469104820gmail_msg">
<br class="m_5045187437469104820gmail_msg">
</blockquote></div><br class="m_5045187437469104820gmail_msg"></div></div></div>
</blockquote></div></div>
</blockquote></div><br></div>