<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 2/24/17 1:48 PM, Eric Fiselier
wrote:<br>
</div>
<blockquote
cite="mid:CAB=TDAXzqsxLOK1An0FdDa2yC90QNeJQBBZAGCEs_k_q4MizmQ@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div dir="ltr">Inserting arbitrary feature macros into CMake
should not be a supported scenario because it results is macros,
such as this one, which are seemingly dead.</div>
</blockquote>
<br>
Good point.<br>
<br>
<br>
Jon<br>
<br>
<blockquote
cite="mid:CAB=TDAXzqsxLOK1An0FdDa2yC90QNeJQBBZAGCEs_k_q4MizmQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div><br>
</div>
<div>/Eric</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Feb 24, 2017 at 1:44 PM,
Jonathan Roelofs <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:jonathan@codesourcery.com" target="_blank">jonathan@codesourcery.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class=""><br>
<br>
On 2/24/17 1:30 PM, Eric Fiselier via Phabricator wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
EricWF added a comment.<br>
<br>
In <a moz-do-not-send="true"
href="https://reviews.llvm.org/D30339#685921"
rel="noreferrer" target="_blank">https://reviews.llvm.org/D3033<wbr>9#685921</a>,
@jroelofs wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
In <a moz-do-not-send="true"
href="https://reviews.llvm.org/D30339#685919"
rel="noreferrer" target="_blank">https://reviews.llvm.org/D3033<wbr>9#685919</a>,
@rmaprath wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Perhaps change `config.h` and remove the definition
there and adjust other places accordingly?<br>
<br>
The current form is very easy to trip over.<br>
</blockquote>
<br>
Eric's point is that LIBCXXABI_BAREMETAL is a 0/1
flag, not a defined/not-defined flag. Please don't
change from one form to the other... it's disruptive
to build systems.<br>
</blockquote>
<br>
I actually think it's better to maintain consistency
between libc++ and libc++abi. And libc++ never uses 0/1
flags. So I would rather see a fix in `config.h`.<br>
<br>
Frankly I don't care that it is disruptive to build
systems unless it's the build system owned by LLVM.<br>
</blockquote>
<br>
</span>
What I really care about is the interface between the build
system owned by LLVM, and the one driving it.<br>
<br>
<br>
Jon
<div class="HOEnZb">
<div class="h5"><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a moz-do-not-send="true"
href="https://reviews.llvm.org/D30339"
rel="noreferrer" target="_blank">https://reviews.llvm.org/D3033<wbr>9</a><br>
<br>
<br>
<br>
</blockquote>
<br>
</div>
</div>
<span class="HOEnZb"><font color="#888888">
-- <br>
Jon Roelofs<br>
<a moz-do-not-send="true"
href="mailto:jonathan@codesourcery.com"
target="_blank">jonathan@codesourcery.com</a><br>
CodeSourcery / Mentor Embedded<br>
<br>
</font></span></blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Jon Roelofs
<a class="moz-txt-link-abbreviated" href="mailto:jonathan@codesourcery.com">jonathan@codesourcery.com</a>
CodeSourcery / Mentor Embedded</pre>
</body>
</html>