<p dir="ltr">The PPC one should inherit from this. You're right I should have tested it though. Mostly ppc Darwin isn't well supported. </p>
<br><div class="gmail_quote"><div dir="ltr">On Wed, Feb 15, 2017, 12:06 AM Tim Shen <<a href="mailto:timshen@google.com">timshen@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Wed, Feb 15, 2017, 00:01 Eric Christopher via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: echristo<br class="gmail_msg">
Date: Wed Feb 15 01:50:11 2017<br class="gmail_msg">
New Revision: 295156<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=295156&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=295156&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Add a definition for __STRUCT_PARM_ALIGN__ for elfv2 and 64-bit darwin platforms to match what other compilers produce.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    cfe/trunk/lib/Basic/Targets.cpp<br class="gmail_msg">
    cfe/trunk/test/Preprocessor/init.c<br class="gmail_msg">
<br class="gmail_msg">
Modified: cfe/trunk/lib/Basic/Targets.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=295156&r1=295155&r2=295156&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=295156&r1=295155&r2=295156&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- cfe/trunk/lib/Basic/Targets.cpp (original)<br class="gmail_msg">
+++ cfe/trunk/lib/Basic/Targets.cpp Wed Feb 15 01:50:11 2017<br class="gmail_msg">
@@ -1232,6 +1232,11 @@ void PPCTargetInfo::getTargetDefines(con<br class="gmail_msg">
   if (LongDoubleWidth == 128)<br class="gmail_msg">
     Builder.defineMacro("__LONG_DOUBLE_128__");<br class="gmail_msg">
<br class="gmail_msg">
+  // Define this for elfv2 (64-bit only) or 64-bit darwin.<br class="gmail_msg">
+  if (ABI == "elfv2" ||<br class="gmail_msg">
+      (getTriple().getOS() == llvm::Triple::Darwin && PointerWidth == 64))<br class="gmail_msg"></blockquote></div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">I also see a "DarwinTargetInfo". Maybe this should be put there as well?</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_quote gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+    Builder.defineMacro("__STRUCT_PARM_ALIGN__", "16");<br class="gmail_msg">
+<br class="gmail_msg">
   if (Opts.AltiVec) {<br class="gmail_msg">
     Builder.defineMacro("__VEC__", "10206");<br class="gmail_msg">
     Builder.defineMacro("__ALTIVEC__");<br class="gmail_msg">
<br class="gmail_msg">
Modified: cfe/trunk/test/Preprocessor/init.c<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Preprocessor/init.c?rev=295156&r1=295155&r2=295156&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Preprocessor/init.c?rev=295156&r1=295155&r2=295156&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- cfe/trunk/test/Preprocessor/init.c (original)<br class="gmail_msg">
+++ cfe/trunk/test/Preprocessor/init.c Wed Feb 15 01:50:11 2017<br class="gmail_msg">
@@ -5635,6 +5635,7 @@<br class="gmail_msg">
 // PPC64LE:#define __SIZE_MAX__ 18446744073709551615UL<br class="gmail_msg">
 // PPC64LE:#define __SIZE_TYPE__ long unsigned int<br class="gmail_msg">
 // PPC64LE:#define __SIZE_WIDTH__ 64<br class="gmail_msg">
+// PPC64LE:#define __STRUCT_PARM_ALIGN__ 16<br class="gmail_msg">
 // PPC64LE:#define __UINT16_C_SUFFIX__<br class="gmail_msg">
 // PPC64LE:#define __UINT16_MAX__ 65535<br class="gmail_msg">
 // PPC64LE:#define __UINT16_TYPE__ unsigned short<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg">
</blockquote></div>
</blockquote></div>