<div dir="ltr">Hi Hans,<div><br></div><div>Would you mind grabbing this for the 4.0 release as well?  It's merely correcting the documentation, so should have no impact on the toolchain itself.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Feb 11, 2017 at 9:24 AM, Saleem Abdulrasool via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: compnerd<br>
Date: Sat Feb 11 11:24:09 2017<br>
New Revision: 294855<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=294855&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=294855&view=rev</a><br>
Log:<br>
docs: update docs for objc_storeStrong behaviour<br>
<br>
objc_storeStrong does not return a value.<br>
<br>
Modified:<br>
    cfe/trunk/docs/<wbr>AutomaticReferenceCounting.rst<br>
    cfe/trunk/lib/CodeGen/<wbr>CodeGenModule.h<br>
<br>
Modified: cfe/trunk/docs/<wbr>AutomaticReferenceCounting.rst<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/AutomaticReferenceCounting.rst?rev=294855&r1=294854&r2=294855&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/docs/<wbr>AutomaticReferenceCounting.<wbr>rst?rev=294855&r1=294854&r2=<wbr>294855&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/docs/<wbr>AutomaticReferenceCounting.rst (original)<br>
+++ cfe/trunk/docs/<wbr>AutomaticReferenceCounting.rst Sat Feb 11 11:24:09 2017<br>
@@ -2258,16 +2258,13 @@ non-block type [*]_.  Equivalent to the<br>
<br>
 .. code-block:: objc<br>
<br>
-  id objc_storeStrong(id *object, id value) {<br>
-    value = [value retain];<br>
+  void objc_storeStrong(id *object, id value) {<br>
     id oldValue = *object;<br>
+    value = [value retain];<br>
     *object = value;<br>
     [oldValue release];<br>
-    return value;<br>
   }<br>
<br>
-Always returns ``value``.<br>
-<br>
 .. [*] This does not imply that a ``__strong`` object of block type is an<br>
    invalid argument to this function. Rather it implies that an ``objc_retain``<br>
    and not an ``objc_retainBlock`` operation will be emitted if the argument is<br>
<br>
Modified: cfe/trunk/lib/CodeGen/<wbr>CodeGenModule.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenModule.h?rev=294855&r1=294854&r2=294855&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/CodeGen/<wbr>CodeGenModule.h?rev=294855&r1=<wbr>294854&r2=294855&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/lib/CodeGen/<wbr>CodeGenModule.h (original)<br>
+++ cfe/trunk/lib/CodeGen/<wbr>CodeGenModule.h Sat Feb 11 11:24:09 2017<br>
@@ -166,7 +166,7 @@ struct ObjCEntrypoints {<br>
   /// void objc_release(id);<br>
   llvm::Constant *objc_release;<br>
<br>
-  /// id objc_storeStrong(id*, id);<br>
+  /// void objc_storeStrong(id*, id);<br>
   llvm::Constant *objc_storeStrong;<br>
<br>
   /// id objc_storeWeak(id*, id);<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div>