<div dir="ltr">r294676<br></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Feb 9, 2017 at 4:05 PM David L. Jones via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">dlj added inline comments.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
================<br class="gmail_msg">
Comment at: cfe/trunk/lib/CodeGen/MacroPPCallbacks.cpp:125<br class="gmail_msg">
+  switch (Status) {<br class="gmail_msg">
+  default:<br class="gmail_msg">
+    llvm_unreachable("Do not expect to enter a file from current scope");<br class="gmail_msg">
----------------<br class="gmail_msg">
As a heads up... this fails under -Werror:<br class="gmail_msg">
<br class="gmail_msg">
llvm/tools/clang/lib/CodeGen/MacroPPCallbacks.cpp:125:3: error: default label in switch which covers all enumeration values [-Werror,-Wcovered-switch-default]<br class="gmail_msg">
  default:<br class="gmail_msg">
  ^<br class="gmail_msg">
1 error generated.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Repository:<br class="gmail_msg">
  rL LLVM<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D16135" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D16135</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>