<div dir="ltr">Adrian has filed PR 31860 at <a href="https://llvm.org/bugs/show_bug.cgi?id=31860">https://llvm.org/bugs/show_bug.cgi?id=31860</a> .</div><div class="gmail_extra"><br><div class="gmail_quote">On 3 February 2017 at 23:10, Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Note that this also failed on Linux:<br>
<a href="http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/2728" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/<wbr>builders/clang-x86_64-linux-<wbr>selfhost-modules/builds/2728</a><br>
<br>
This looks like a modules compiler bug, as opposed to a problem in the commit itself. Alex, can you file a PR for this?<br>
<div class="HOEnZb"><div class="h5"><br>
> On 2017-Feb-01, at 07:35, Alex L via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
><br>
> I've narrowed the problem down to the difference in the linkage type for "clang::ast_matchers::<wbr>recordDecl" between the module and non-module build:<br>
><br>
> Module:<br>
> @_ZN5clang12ast_<wbr>matchersL10recordDeclE = external global %"class.clang::ast_matchers::<wbr>internal::<wbr>VariadicDynCastAllOfMatcher.<wbr>847", align 1<br>
><br>
> Non-module:<br>
> @_ZN5clang12ast_<wbr>matchersL10recordDeclE = internal constant %"class.clang::ast_matchers::<wbr>internal::<wbr>VariadicDynCastAllOfMatcher.<wbr>916" undef, align 1, !dbg !7<br>
><br>
> On 1 February 2017 at 11:03, Alex L <<a href="mailto:arphaman@gmail.com">arphaman@gmail.com</a>> wrote:<br>
> Hi Benjamin,<br>
><br>
> This commit has caused a linking in our stage 2 modules buildbot at <a href="http://lab.llvm.org:8080/green/job/clang-stage2-cmake-modulesRDA/" rel="noreferrer" target="_blank">http://lab.llvm.org:8080/<wbr>green/job/clang-stage2-cmake-<wbr>modulesRDA/</a>. Specifically, after this commit 'clang-reorder-fields' gets the following linking error:<br>
><br>
> FAILED: bin/clang-reorder-fields<br>
> : && /Users/buildslave/jenkins/<wbr>sharedspace/clang-stage2-<wbr>cmake-modulesRDA@2/host-<wbr>compiler/bin/clang++ -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -Werror=date-time -std=c++11 -fmodules -fmodules-cache-path=/Users/<wbr>buildslave/jenkins/<wbr>sharedspace/clang-stage2-<wbr>cmake-modulesRDA@2/clang-<wbr>build/module.cache -fcxx-modules -gmodules -fcolor-diagnostics -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O2 -g -DNDEBUG -Wl,-search_paths_first -Wl,-headerpad_max_install_<wbr>names -Wl,-dead_strip tools/clang/tools/extra/clang-<wbr>reorder-fields/tool/<wbr>CMakeFiles/clang-reorder-<wbr>fields.dir/ClangReorderFields.<wbr>cpp.o -o bin/clang-reorder-fields lib/libLLVMSupport.a lib/libclangBasic.a lib/libclangFrontend.a lib/libclangReorderFields.a lib/libclangRewrite.a lib/libclangTooling.a lib/libclangToolingCore.a lib/libclangIndex.a lib/libclangFrontend.a lib/libclangParse.a lib/libLLVMMCParser.a lib/libclangSerialization.a lib/libclangSema.a lib/libclangEdit.a lib/libclangAnalysis.a lib/libLLVMBitReader.a lib/libLLVMProfileData.a lib/libclangDriver.a lib/libLLVMOption.a lib/libclangASTMatchers.a lib/libclangFormat.a lib/libclangToolingCore.a lib/libclangRewrite.a lib/libclangAST.a lib/libclangLex.a lib/libclangBasic.a lib/libLLVMCore.a lib/libLLVMMC.a lib/libLLVMSupport.a -lcurses -lz -lm lib/libLLVMDemangle.a -Wl,-rpath,@loader_path/../lib && :<br>
> Undefined symbols for architecture x86_64:<br>
> "clang::ast_matchers::<wbr>recordDecl", referenced from:<br>
> clang::reorder_fields::(<wbr>anonymous namespace)::<wbr>ReorderingConsumer::<wbr>HandleTranslationUnit(clang::<wbr>ASTContext&) in libclangReorderFields.a(<wbr>ReorderFieldsAction.cpp.o)<br>
> ld: symbol(s) not found for architecture x86_64<br>
><br>
> This might be a bug/regression in clang and modules since in my opinion the link should succeed. I've reverted your commit in r293759 while we are investigating.<br>
><br>
> Thanks,<br>
> Alex<br>
><br>
><br>
> On 30 January 2017 at 18:20, Benjamin Kramer via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
> Author: d0k<br>
> Date: Mon Jan 30 12:20:00 2017<br>
> New Revision: 293518<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=293518&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=293518&view=rev</a><br>
> Log:<br>
> [ASTMatchers] Sprinkle some constexpr on the global matcher constructors.<br>
><br>
> This dramatically reduces the size of the global constructors we emit<br>
> for those variables in debug mode.<br>
><br>
> Modified:<br>
> cfe/trunk/include/clang/<wbr>ASTMatchers/<wbr>ASTMatchersInternal.h<br>
><br>
> Modified: cfe/trunk/include/clang/<wbr>ASTMatchers/<wbr>ASTMatchersInternal.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/ASTMatchers/ASTMatchersInternal.h?rev=293518&r1=293517&r2=293518&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/include/<wbr>clang/ASTMatchers/<wbr>ASTMatchersInternal.h?rev=<wbr>293518&r1=293517&r2=293518&<wbr>view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- cfe/trunk/include/clang/<wbr>ASTMatchers/<wbr>ASTMatchersInternal.h (original)<br>
> +++ cfe/trunk/include/clang/<wbr>ASTMatchers/<wbr>ASTMatchersInternal.h Mon Jan 30 12:20:00 2017<br>
> @@ -1459,7 +1459,7 @@ class VariadicDynCastAllOfMatcher<br>
> : public VariadicFunction<<wbr>BindableMatcher<SourceT>, Matcher<TargetT>,<br>
> makeDynCastAllOfComposite<<wbr>SourceT, TargetT>> {<br>
> public:<br>
> - VariadicDynCastAllOfMatcher() {}<br>
> + constexpr VariadicDynCastAllOfMatcher() {}<br>
> };<br>
><br>
> /// \brief A \c VariadicAllOfMatcher<T> object is a variadic functor that takes<br>
> @@ -1477,7 +1477,7 @@ class VariadicAllOfMatcher<br>
> : public VariadicFunction<<wbr>BindableMatcher<T>, Matcher<T>,<br>
> makeAllOfComposite<T>> {<br>
> public:<br>
> - VariadicAllOfMatcher() {}<br>
> + constexpr VariadicAllOfMatcher() {}<br>
> };<br>
><br>
> /// \brief Matches nodes of type \c TLoc for which the inner<br>
> @@ -1598,7 +1598,7 @@ public:<br>
><br>
> struct Func<br>
> : public VariadicFunction<Self, Matcher<InnerTBase>, &Self::create> {<br>
> - Func() {}<br>
> + constexpr Func() {}<br>
> };<br>
><br>
> private:<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
<br>
</div></div></blockquote></div><br></div>