<div dir="ltr">I've attached LLVM IR for for "ReorderFieldsAction.cpp" that was used to generate the object file that failed the linkage. I think the following line in the IR corresponds to symbol that wasn't found during linkage:<div><br></div><div>
<pre style="margin-top:0px;margin-bottom:0px">@_ZN5clang12ast_matchersL10recordDeclE<span style="color:rgb(192,192,192)"> </span>=<span style="color:rgb(192,192,192)"> </span>external<span style="color:rgb(192,192,192)"> </span>global<span style="color:rgb(192,192,192)"> </span>%"class.clang::ast_matchers::internal::VariadicDynCastAllOfMatcher.847",<span style="color:rgb(192,192,192)"> </span>align<span style="color:rgb(192,192,192)"> </span>1</pre><div><div class="gmail_extra"><br><div class="gmail_quote">On 1 February 2017 at 11:03, Alex L <span dir="ltr"><<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Benjamin,<div><br></div><div>This commit has caused a linking in our stage 2 modules buildbot at <a href="http://lab.llvm.org:8080/green/job/clang-stage2-cmake-modulesRDA/" target="_blank">http://lab.llvm.org:8080/<wbr>green/job/clang-stage2-cmake-<wbr>modulesRDA/</a>. Specifically, after this commit 'clang-reorder-fields' gets the following linking error:</div><div><br></div><div><div>FAILED: bin/clang-reorder-fields </div><div>: && /Users/buildslave/jenkins/<wbr>sharedspace/clang-stage2-<wbr>cmake-modulesRDA@2/host-<wbr>compiler/bin/clang++ -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -Werror=date-time -std=c++11 -fmodules -fmodules-cache-path=/Users/<wbr>buildslave/jenkins/<wbr>sharedspace/clang-stage2-<wbr>cmake-modulesRDA@2/clang-<wbr>build/module.cache -fcxx-modules -gmodules -fcolor-diagnostics -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O2 -g -DNDEBUG -Wl,-search_paths_first -Wl,-headerpad_max_install_<wbr>names -Wl,-dead_strip tools/clang/tools/extra/clang-<wbr>reorder-fields/tool/<wbr>CMakeFiles/clang-reorder-<wbr>fields.dir/ClangReorderFields.<wbr>cpp.o -o bin/clang-reorder-fields lib/libLLVMSupport.a lib/libclangBasic.a lib/libclangFrontend.a lib/libclangReorderFields.a lib/libclangRewrite.a lib/libclangTooling.a lib/libclangToolingCore.a lib/libclangIndex.a lib/libclangFrontend.a lib/libclangParse.a lib/libLLVMMCParser.a lib/libclangSerialization.a lib/libclangSema.a lib/libclangEdit.a lib/libclangAnalysis.a lib/libLLVMBitReader.a lib/libLLVMProfileData.a lib/libclangDriver.a lib/libLLVMOption.a lib/libclangASTMatchers.a lib/libclangFormat.a lib/libclangToolingCore.a lib/libclangRewrite.a lib/libclangAST.a lib/libclangLex.a lib/libclangBasic.a lib/libLLVMCore.a lib/libLLVMMC.a lib/libLLVMSupport.a -lcurses -lz -lm lib/libLLVMDemangle.a -Wl,-rpath,@loader_path/../lib && :</div><div>Undefined symbols for architecture x86_64:</div><div> "clang::ast_matchers::<wbr>recordDecl", referenced from:</div><div> clang::reorder_fields::(<wbr>anonymous namespace)::<wbr>ReorderingConsumer::<wbr>HandleTranslationUnit(clang::<wbr>ASTContext&) in libclangReorderFields.a(<wbr>ReorderFieldsAction.cpp.o)</div><div>ld: symbol(s) not found for architecture x86_64</div></div><div><br></div><div>This might be a bug/regression in clang and modules since in my opinion the link should succeed. I've reverted your commit in r293759 while we are investigating.</div><div><br></div><div>Thanks,</div><div>Alex</div><div><br></div></div><div class="gmail-HOEnZb"><div class="gmail-h5"><div class="gmail_extra"><br><div class="gmail_quote">On 30 January 2017 at 18:20, Benjamin Kramer via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Author: d0k<br>
Date: Mon Jan 30 12:20:00 2017<br>
New Revision: 293518<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=293518&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=293518&view=rev</a><br>
Log:<br>
[ASTMatchers] Sprinkle some constexpr on the global matcher constructors.<br>
<br>
This dramatically reduces the size of the global constructors we emit<br>
for those variables in debug mode.<br>
<br>
Modified:<br>
cfe/trunk/include/clang/ASTMat<wbr>chers/ASTMatchersInternal.h<br>
<br>
Modified: cfe/trunk/include/clang/ASTMat<wbr>chers/ASTMatchersInternal.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/ASTMatchers/ASTMatchersInternal.h?rev=293518&r1=293517&r2=293518&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/cfe/trunk/include/clang/<wbr>ASTMatchers/ASTMatchersInterna<wbr>l.h?rev=293518&r1=293517&r2=<wbr>293518&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/include/clang/ASTMat<wbr>chers/ASTMatchersInternal.h (original)<br>
+++ cfe/trunk/include/clang/ASTMat<wbr>chers/ASTMatchersInternal.h Mon Jan 30 12:20:00 2017<br>
@@ -1459,7 +1459,7 @@ class VariadicDynCastAllOfMatcher<br>
: public VariadicFunction<BindableMatch<wbr>er<SourceT>, Matcher<TargetT>,<br>
makeDynCastAllOfComposite<Sou<wbr>rceT, TargetT>> {<br>
public:<br>
- VariadicDynCastAllOfMatcher() {}<br>
+ constexpr VariadicDynCastAllOfMatcher() {}<br>
};<br>
<br>
/// \brief A \c VariadicAllOfMatcher<T> object is a variadic functor that takes<br>
@@ -1477,7 +1477,7 @@ class VariadicAllOfMatcher<br>
: public VariadicFunction<BindableMatch<wbr>er<T>, Matcher<T>,<br>
makeAllOfComposite<T>> {<br>
public:<br>
- VariadicAllOfMatcher() {}<br>
+ constexpr VariadicAllOfMatcher() {}<br>
};<br>
<br>
/// \brief Matches nodes of type \c TLoc for which the inner<br>
@@ -1598,7 +1598,7 @@ public:<br>
<br>
struct Func<br>
: public VariadicFunction<Self, Matcher<InnerTBase>, &Self::create> {<br>
- Func() {}<br>
+ constexpr Func() {}<br>
};<br>
<br>
private:<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div></div></div></div>