<div dir="ltr">This review thread is missing on-list approval. I assume it happened on Phab & just wasn't reflected here (if the Phab approval has no text it doesn't send an email, which is unfortunate - not sure if anyone's planning to fix that/change the settings, but until then it's helpful to include "LGTM" or something in the comment field when approving)</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Jan 23, 2017 at 5:16 PM David L. Jones via Phabricator via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br class="gmail_msg">
Closed by commit rL292868: Switch TableGen to emit calls to ASTRecordReader for AttrPCHRead. (authored by dlj).<br class="gmail_msg">
<br class="gmail_msg">
Changed prior to commit:<br class="gmail_msg">
  <a href="https://reviews.llvm.org/D28007?vs=85493&id=85498#toc" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D28007?vs=85493&id=85498#toc</a><br class="gmail_msg">
<br class="gmail_msg">
Repository:<br class="gmail_msg">
  rL LLVM<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D28007" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D28007</a><br class="gmail_msg">
<br class="gmail_msg">
Files:<br class="gmail_msg">
  cfe/trunk/include/clang/Serialization/ASTReader.h<br class="gmail_msg">
  cfe/trunk/lib/Serialization/ASTReaderDecl.cpp<br class="gmail_msg">
  cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg">
</blockquote></div>