<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jan 27, 2017, at 2:44 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Jan 27, 2017 at 2:11 PM Mehdi AMINI via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="">reviews@reviews.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">mehdi_amini accepted this revision.<br class="gmail_msg">mehdi_amini added a comment.<br class="gmail_msg">This revision is now accepted and ready to land.<br class="gmail_msg"><br class="gmail_msg">LGTM.<br class="gmail_msg"><br class="gmail_msg"><br class="gmail_msg"><br class="gmail_msg">================<br class="gmail_msg">Comment at: lib/AST/ASTContext.cpp:8909<br class="gmail_msg">+<br class="gmail_msg">+ // Itanium ABI (& MSVC seems to do similarly) requires static locals in<br class="gmail_msg">+ // inline functions to be emitted anywhere they're needed, even if the<br class="gmail_msg">----------------<br class="gmail_msg">I assume you looked it up, do you have a ref? (Citation or pointer to right section/paragraph).<br class="gmail_msg"></blockquote><div class=""><br class="">Would you like a citation in source?</div></div></div></div></blockquote><div><br class=""></div><div>Sure, why not?</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote"><div class=""> I thought that might be a bit strong since this is ABI-neutral code, notionally (so I was straddling that line a bit).<br class=""></div></div></div></div></blockquote><div><br class=""></div><div>Well you refer to the ABI anyway already to explain the chosen behavior :)</div><div><br class=""></div><div>And technically I’m not sure what the C++ standard mandates, the possibility of having different need for different ABI would indicate that the code can’t be totally ABI-neutral?</div><div><br class=""></div><div>— </div><div>Mehdi</div><div> </div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote"><div class=""><br class="">I can't quite figure out how to navigate/find the ABI document nor cast the runes as Richard did for the citation, so hopefully he can chime in here.<br class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><br class="gmail_msg"><br class="gmail_msg"><a href="https://reviews.llvm.org/D29233" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D29233</a></blockquote></div></div></div></blockquote></div><br class=""></body></html>