<div dir="ltr">Sure, why not.</div><div class="gmail_extra"><br><div class="gmail_quote">On 26 January 2017 at 15:56, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">A candidate for clang 4?<br>
<div class="HOEnZb"><div class="h5"><br>
On Thu, Jan 19, 2017 at 5:19 PM, Richard Smith via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
> Author: rsmith<br>
> Date: Thu Jan 19 19:19:46 2017<br>
> New Revision: 292561<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=292561&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=292561&view=rev</a><br>
> Log:<br>
> PR31701: Fix crash on invalid caused by parsing a dependent initializer when we<br>
> don't know we're in a dependent context.<br>
><br>
> Modified:<br>
>     cfe/trunk/lib/AST/ASTContext.<wbr>cpp<br>
>     cfe/trunk/test/SemaCXX/<wbr>constant-expression.cpp<br>
><br>
> Modified: cfe/trunk/lib/AST/ASTContext.<wbr>cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTContext.cpp?rev=292561&r1=292560&r2=292561&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/AST/<wbr>ASTContext.cpp?rev=292561&r1=<wbr>292560&r2=292561&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- cfe/trunk/lib/AST/ASTContext.<wbr>cpp (original)<br>
> +++ cfe/trunk/lib/AST/ASTContext.<wbr>cpp Thu Jan 19 19:19:46 2017<br>
> @@ -9021,7 +9021,8 @@ bool ASTContext::DeclMustBeEmitted(<wbr>const<br>
><br>
>    // Variables that have initialization with side-effects are required.<br>
>    if (VD->getInit() && VD->getInit()->HasSideEffects(<wbr>*this) &&<br>
> -      !VD->evaluateValue())<br>
> +      // We can get a value-dependent initializer during error recovery.<br>
> +      (VD->getInit()-><wbr>isValueDependent() || !VD->evaluateValue()))<br>
>      return true;<br>
><br>
>    // Likewise, variables with tuple-like bindings are required if their<br>
><br>
> Modified: cfe/trunk/test/SemaCXX/<wbr>constant-expression.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/constant-expression.cpp?rev=292561&r1=292560&r2=292561&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/test/<wbr>SemaCXX/constant-expression.<wbr>cpp?rev=292561&r1=292560&r2=<wbr>292561&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- cfe/trunk/test/SemaCXX/<wbr>constant-expression.cpp (original)<br>
> +++ cfe/trunk/test/SemaCXX/<wbr>constant-expression.cpp Thu Jan 19 19:19:46 2017<br>
> @@ -143,3 +143,14 @@ namespace rdar16064952 {<br>
>  }<br>
><br>
>  char PR17381_ice = 1000000 * 1000000; // expected-warning {{overflow}} expected-warning {{changes value}}<br>
> +<br>
> +namespace PR31701 {<br>
> +  struct C {<br>
> +    template<int i> static int n; // expected-warning {{extension}}<br>
> +  };<br>
> +  template <int M> class D;<br>
> +  template <int M><br>
> +  template<int i> void D<M>::set() { // expected-error {{from class 'D<M>' without definition}}<br>
> +    const C c = C::n<i>;<br>
> +  }<br>
> +}<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>