<div dir="ltr">We should merge this patch into the 4.0 release branch. It is needed to make "check-all" pass when using GCC 4, 5 and 6.<div><br></div><div>/Eric</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 20, 2017 at 5:54 AM, Eric Fiselier via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ericwf<br>
Date: Fri Jan 20 06:54:45 2017<br>
New Revision: 292607<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=292607&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=292607&view=rev</a><br>
Log:<br>
Don't default older GCC's to C++17, but C++14 or C++11 instead<br>
<br>
Modified:<br>
    libcxx/trunk/test/libcxx/test/<wbr>config.py<br>
<br>
Modified: libcxx/trunk/test/libcxx/test/<wbr>config.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/test/config.py?rev=292607&r1=292606&r2=292607&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/test/<wbr>libcxx/test/config.py?rev=<wbr>292607&r1=292606&r2=292607&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/libcxx/test/<wbr>config.py (original)<br>
+++ libcxx/trunk/test/libcxx/test/<wbr>config.py Fri Jan 20 06:54:45 2017<br>
@@ -423,6 +423,15 @@ class Configuration(object):<br>
         if not std:<br>
             # Choose the newest possible language dialect if none is given.<br>
             possible_stds = ['c++1z', 'c++14', 'c++11', 'c++03']<br>
+            if self.cxx.type == 'gcc':<br>
+                maj_v, _, _ = self.cxx.version<br>
+                maj_v = int(maj_v)<br>
+                if maj_v < 7:<br>
+                    possible_stds.remove('c++1z')<br>
+                # FIXME: How many C++14 tests actually fail under GCC 5 and 6?<br>
+                # Should we XFAIL them individually instead?<br>
+                if maj_v <= 6:<br>
+                    possible_stds.remove('c++14')<br>
             for s in possible_stds:<br>
                 if self.cxx.hasCompileFlag('-std=<wbr>%s' % s):<br>
                     std = s<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>