<div>FTR, this wasn't changed with the renaming.</div><div><br></div><div>But, taking a look at it does seem that it is off by one.  Well spotted!</div><div><br><div class="gmail_quote"><div>On Thu, Jan 5, 2017 at 7:16 PM David Majnemer <<a href="mailto:david.majnemer@gmail.com">david.majnemer@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_msg"><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg">On Thu, Jan 5, 2017 at 3:25 PM, Saleem Abdulrasool via cfe-commits <span class="gmail_msg"><<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: compnerd<br class="gmail_msg"><br><br>Date: Thu Jan  5 17:25:44 2017<br class="gmail_msg"><br><br>New Revision: 291192<br class="gmail_msg"><br><br><br class="gmail_msg"><br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=291192&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=291192&view=rev</a><br class="gmail_msg"><br><br>Log:<br class="gmail_msg"><br><br>config_elast: fix typo (NFC)<br class="gmail_msg"><br><br><br class="gmail_msg"><br><br>Missed the original typo which was duplicated.  NFC.<br class="gmail_msg"><br><br><br class="gmail_msg"><br><br>Modified:<br class="gmail_msg"><br><br>    libcxx/trunk/src/include/config_elast.h<br class="gmail_msg"><br><br><br class="gmail_msg"><br><br>Modified: libcxx/trunk/src/include/config_elast.h<br class="gmail_msg"><br><br>URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/src/include/config_elast.h?rev=291192&r1=291191&r2=291192&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/libcxx/trunk/src/include/config_elast.h?rev=291192&r1=291191&r2=291192&view=diff</a><br class="gmail_msg"><br><br>==============================================================================<br class="gmail_msg"><br><br>--- libcxx/trunk/src/include/config_elast.h (original)<br class="gmail_msg"><br><br>+++ libcxx/trunk/src/include/config_elast.h Thu Jan  5 17:25:44 2017<br class="gmail_msg"><br><br>@@ -30,7 +30,7 @@<br class="gmail_msg"><br><br> // No _LIBCPP_ELAST needed on Apple<br class="gmail_msg"><br><br> #elif defined(__sun__)<br class="gmail_msg"><br><br> #define _LIBCPP_ELAST ESTALE<br class="gmail_msg"><br><br>-#elif defined(_LIBCPP_MSCVRT)<br class="gmail_msg"><br><br>+#elif defined(_LIBCPP_MSVCRT)<br class="gmail_msg"><br><br> #define _LIBCPP_ELAST _sys_nerr<br class="gmail_msg"></blockquote><div class="gmail_msg"><br class="gmail_msg"></div></div></div></div><div class="gmail_msg"><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg"><div class="gmail_msg">Isn't ELAST supposed to point to a valid error number? Shouldn't this be _sys_nerr-1?</div></div></div></div><div class="gmail_msg"><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg"><div class="gmail_msg"> </div><blockquote class="gmail_quote gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br><br> #else<br class="gmail_msg"><br><br> // Warn here so that the person doing the libcxx port has an easier time:<br class="gmail_msg"><br><br><br class="gmail_msg"><br><br><br class="gmail_msg"><br><br>_______________________________________________<br class="gmail_msg"><br><br>cfe-commits mailing list<br class="gmail_msg"><br><br><a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg"><br><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg"><br><br></blockquote></div></div></div></blockquote></div></div>