<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 1/4/17 2:52 AM, Dylan McKay wrote:<br>
</div>
<blockquote
cite="mid:CAHAccTMFte2t_wAtnAk--Y2Z68ipOppar8AsvOya1vt3D6MjKg@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div dir="ltr">I've just raised a bug here
<div><br>
</div>
<div><a moz-do-not-send="true"
href="https://llvm.org/bugs/show_bug.cgi?id=31530">https://llvm.org/bugs/show_bug.cgi?id=31530</a><br>
</div>
<div><br>
</div>
<div>> <span style="font-size:12.8px">What's necessary for
sign-off? Should I ping the reviewer (Richard Smith) again?</span></div>
<div><span style="font-size:12.8px"><br>
</span></div>
<div><span style="font-size:12.8px">I think so long as Richard
or someone else who actively works on Clang signs off.
Perhaps somebody else is keen to review?</span></div>
<div><span style="font-size:12.8px"><br>
</span></div>
<div><span style="font-size:12.8px">On the other hand, I can
review it and then ask if there aren't any objections to it
being in-tree within a few days, I can commit it. <br>
</span></div>
</div>
</blockquote>
<br>
LGTM<br>
<br>
<br>
Jon<br>
<br>
<blockquote
cite="mid:CAHAccTMFte2t_wAtnAk--Y2Z68ipOppar8AsvOya1vt3D6MjKg@mail.gmail.com"
type="cite">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Jan 4, 2017 at 7:20 PM, Senthil
Kumar Selvaraj <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:senthilkumar.selvaraj@microchip.com"
target="_blank">senthilkumar.selvaraj@microchip.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class=""><br>
Dylan McKay writes:<br>
<br>
> Did you get the BugZilla account sorted Senthil?<br>
<br>
</span>Nope, direct email also didn't help. Can you please
file a bug with<br>
<br>
Title:<br>
<br>
UINT16_TYPE and INT16_TYPE are defined as short instead of
int for AVR<br>
<br>
Description:<br>
<br>
UINT16_TYPE and INT16_TYPE are implicitly defined by the
preprocessor<br>
to the short type, rather than int. While shorts and ints
are both<br>
16 bits wide on the avr, gcc picks ints to represent 16
bits wherever<br>
possible, and picking short can cause issues with C++
name mangling<br>
(see <a moz-do-not-send="true"
href="https://reviews.llvm.org/D27123#615854"
rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D27123#615854</a>).
Therefore, clang should<br>
define the two types to short.<br>
<br>
Clang's lib/Frontend/InitPreprocessor.<wbr>cpp::DefineExactWidthIntType
does not<br>
<span class=""> use TargetInfo::getIntTypeByWidth.
Instead,<br>
InitializePredefinedMacros calls<br>
</span> the function with the specific type
(SignedShort/UnsignedShort), because<br>
<span class=""> getShortWidth() > getCharWidth(), but
getIntWidth() ==<br>
getShortWidth().<br>
<br>
<br>
</span>What's necessary for sign-off? Should I ping the
reviewer (Richard Smith) again?<br>
<br>
Regards<br>
<span class="HOEnZb"><font color="#888888">Senthil<br>
</font></span></blockquote>
</div>
<br>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Jon Roelofs
<a class="moz-txt-link-abbreviated" href="mailto:jonathan@codesourcery.com">jonathan@codesourcery.com</a>
CodeSourcery / Mentor Embedded</pre>
</body>
</html>