<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 30/12/2016 23:12, Richard Smith
wrote:<br>
</div>
<blockquote
cite="mid:CAOfiQqkTni_CaYBy39d2PWM95LirpE72h-sH+JmWYHhYhB8Vqw@mail.gmail.com"
type="cite">
<div dir="auto">
<div>
<div class="gmail_extra">
<div class="gmail_quote">On 30 Dec 2016 3:06 pm, "Simon
Pilgrim via cfe-commits" <<a moz-do-not-send="true"
href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>>
wrote:<br type="attribution">
<blockquote class="quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Author:
rksimon<br>
Date: Fri Dec 30 16:55:33 2016<br>
New Revision: 290773<br>
<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=290773&view=rev"
rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=290773&view=rev</a><br>
Log:<br>
Wdocumentation fix<br>
</blockquote>
</div>
</div>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">Thanks, but please be careful you don't
introduce trailing whitespace changes to unrelated code in the
future.</div>
</div>
</blockquote>
Sorry about that - I'm working on my alt laptop for the holidays and
didn't have the same whitespace diff settings for tortoisesvn -
shouldn't happpen again.<br>
<blockquote
cite="mid:CAOfiQqkTni_CaYBy39d2PWM95LirpE72h-sH+JmWYHhYhB8Vqw@mail.gmail.com"
type="cite">
<div dir="auto">
<div dir="auto">Also perhaps we should turn this warning on by
default for regular selfhosted builds so we don't need to wait
for a buildbot to find issues like this?</div>
</div>
</blockquote>
The buildbots are there for us to unearth these kind of things,
otherwise (in extremis) you'd be asking everyone to test on a much
broader range of compile tools than they perhaps have access to.<br>
<br>
IMO the problem is that these mundane warnings tend to stay
unnoticed in build logs, where people don't go unless the build goes
red - I would be interested in hearing people's thoughts on either
enabling Werror by default in CMake gen and/or enabling Werror on a
wider range of buildbots (gcc/clang/msvc)?<br>
</body>
</html>