<div dir="auto"><div><div class="gmail_extra"><div class="gmail_quote">On 22 Dec 2016 9:32 pm, "Chandler Carruth via cfe-commits" <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div class="quoted-text"><div dir="ltr">On Thu, Dec 22, 2016 at 5:41 PM Richard Smith via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
==============================<wbr>==============================<wbr>==================<br class="m_7106263775898309689gmail_msg">
--- cfe/trunk/include/clang/Basic/<wbr>DiagnosticSemaKinds.td (original)<br class="m_7106263775898309689gmail_msg">
+++ cfe/trunk/include/clang/Basic/<wbr>DiagnosticSemaKinds.td Thu Dec 22 19:30:39 2016<br class="m_7106263775898309689gmail_msg">
@@ -3343,6 +3343,10 @@ def note_ovl_candidate_incomplete_<wbr>deduct<br class="m_7106263775898309689gmail_msg">
 def note_ovl_candidate_<wbr>inconsistent_deduction : Note<<br class="m_7106263775898309689gmail_msg">
     "candidate template ignored: deduced conflicting %select{types|values|"<br class="m_7106263775898309689gmail_msg">
     "templates}0 for parameter %1%diff{ ($ vs. $)|}2,3">;<br class="m_7106263775898309689gmail_msg">
+def note_ovl_candidate_<wbr>inconsistent_deduction_types : Note<<br class="m_7106263775898309689gmail_msg">
+    "candidate template ignored: deduced values %diff{"<br class="m_7106263775898309689gmail_msg">
+    "of conflicting types for parameter %0 (%1 of type $ vs. %3 of type $)|"<br class="m_7106263775898309689gmail_msg">
+    "%1 and %3 of conflicting types for parameter %0|}2,4">;<br class="m_7106263775898309689gmail_msg"></blockquote><div><br></div></div><div>So, this new diagnostic isn't actually covered by any test. Not just is the wording not covered, literally it isn't emitted. There is a bug in the format that we didn't defend against -- having too many '|'s in the %diff alternatives. I added an assert to try to catch this in r290417 and it didn't trigger here because we never process this format.</div><div><br></div><div>Could you add a test covering this?</div></div></div></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Both tests changed in this commit produce this diagnostic. We don't have coverage for the tree-format diagnostic here, though; is that what you're referring to?</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div>I went ahead and fixed the %diff format syntax by inspection in r290417.</div></div></div></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Thanks!</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div></div></div>