<div dir="ltr">I don't know much about who owns this sort of code, nor Vassil's work/responsibility in this area - but if he's OK with it/feels able to sign off on it, that'd be sufficient/fine by me (& others closer to it can pipe up if he seems like not the right person to approve).<br><br>Thanks!<br>- Dave<br><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 19, 2016 at 9:48 AM Sean Callanan <<a href="mailto:scallanan@apple.com">scallanan@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg">David,</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">thanks for keeping an eye on this and sorry for the breach of process.</div><div class="gmail_msg">Would having Vassil approve the changelist (<a href="https://reviews.llvm.org/D27180" class="gmail_msg" target="_blank">https://reviews.llvm.org/D27180</a>) be appropriate?</div><div class="gmail_msg">Let's say if he has any concerns or can't get to it by tomorrow, we revert my patches since they're pretty self-contained.</div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Sean</div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg">On Dec 19, 2016, at 8:55 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="gmail_msg" target="_blank">dblaikie@gmail.com</a>> wrote:</div><br class="m_5895989732242494448Apple-interchange-newline gmail_msg"><div class="gmail_msg"><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><br class="gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Thu, Dec 15, 2016 at 2:18 PM Sean Callanan via Phabricator via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">spyffe updated this revision to Diff 81661.<br class="gmail_msg">spyffe marked 2 inline comments as done.<br class="gmail_msg">spyffe added a comment.<br class="gmail_msg">Herald added a subscriber: jgosnell.<br class="gmail_msg"><br class="gmail_msg">Applied Vassil and Vedant's comments.  I will commit this soon.<br class="gmail_msg"></blockquote><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Was this change approved/accepted by anyone? "commit if no one has objections in <time frame>" isn't generally how LLVM project changes are reviewed/committed.</div><div class="gmail_msg"> </div><blockquote class="gmail_quote gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br class="gmail_msg"><br class="gmail_msg">Repository:<br class="gmail_msg"> <span class="m_5895989732242494448Apple-converted-space gmail_msg"> </span>rL LLVM<br class="gmail_msg"><br class="gmail_msg"><a href="https://reviews.llvm.org/D27180" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D27180</a><br class="gmail_msg"><br class="gmail_msg">Files:<br class="gmail_msg"> <span class="m_5895989732242494448Apple-converted-space gmail_msg"> </span>test/Import/clang-flags/Inputs/S.c<br class="gmail_msg"> <span class="m_5895989732242494448Apple-converted-space gmail_msg"> </span>test/Import/clang-flags/test.c<br class="gmail_msg"> <span class="m_5895989732242494448Apple-converted-space gmail_msg"> </span>test/Import/empty-struct/Inputs/S.c<br class="gmail_msg"> <span class="m_5895989732242494448Apple-converted-space gmail_msg"> </span>test/Import/empty-struct/test.c<br class="gmail_msg"> <span class="m_5895989732242494448Apple-converted-space gmail_msg"> </span>test/Import/error-in-expression/Inputs/S.c<br class="gmail_msg"> <span class="m_5895989732242494448Apple-converted-space gmail_msg"> </span>test/Import/error-in-expression/test.c<br class="gmail_msg"> <span class="m_5895989732242494448Apple-converted-space gmail_msg"> </span>test/Import/error-in-import/Inputs/S.c<br class="gmail_msg"> <span class="m_5895989732242494448Apple-converted-space gmail_msg"> </span>test/Import/error-in-import/test.c<br class="gmail_msg"> <span class="m_5895989732242494448Apple-converted-space gmail_msg"> </span>test/Import/missing-import/test.c<br class="gmail_msg"> <span class="m_5895989732242494448Apple-converted-space gmail_msg"> </span>tools/CMakeLists.txt<br class="gmail_msg"> <span class="m_5895989732242494448Apple-converted-space gmail_msg"> </span>tools/clang-import-test/CMakeLists.txt<br class="gmail_msg"> <span class="m_5895989732242494448Apple-converted-space gmail_msg"> </span>tools/clang-import-test/clang-import-test.cpp<br class="gmail_msg"><br class="gmail_msg">_______________________________________________<br class="gmail_msg">cfe-commits mailing list<br class="gmail_msg"><a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a></blockquote></div></div></div></blockquote></div><br class="gmail_msg"></div></blockquote></div></div>