<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">It was approved by Reid.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">This patch had two parts, he did not stamp the change in Clang, but he did stamp the change for LLVM.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><a href="https://reviews.llvm.org/D27762">https://reviews.llvm.org/D27762</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">I assumed that this means a green light to commit.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Did I misinterpret the rules?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Amjad<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><a name="_____replyseparator"></a><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> David Blaikie [mailto:dblaikie@gmail.com]
<br>
<b>Sent:</b> Monday, December 19, 2016 19:00<br>
<b>To:</b> reviews+D27763+public+4530ee00cad2817d@reviews.llvm.org; Amjad Aboud via Phabricator <reviews@reviews.llvm.org>; Aboud, Amjad <amjad.aboud@intel.com>; rnk@google.com<br>
<b>Cc:</b> cfe-commits@lists.llvm.org<br>
<b>Subject:</b> Re: [PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Was this change approved by anyone? Generally once it's sent for review, you should wait until it's approved before committing (the assumption being, if you sent it for review it's because it needed review)<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Wed, Dec 14, 2016 at 12:49 PM Amjad Aboud via Phabricator via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL289701: [DebugInfo] Changed DIBuilder::createCompileUnit() to take DIFile instead of… (authored by aaboud).<br>
<br>
Changed prior to commit:<br>
<a href="https://reviews.llvm.org/D27763?vs=81397&id=81438#toc" target="_blank">
https://reviews.llvm.org/D27763?vs=81397&id=81438#toc</a><br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D27763" target="_blank">https://reviews.llvm.org/D27763</a><br>
<br>
Files:<br>
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br>
<br>
<br>
Index: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br>
===================================================================<br>
--- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br>
+++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br>
@@ -466,7 +466,8 @@<br>
// Create new compile unit.<br>
// FIXME - Eliminate TheCU.<br>
TheCU = DBuilder.createCompileUnit(<br>
- LangTag, remapDIPath(MainFileName), remapDIPath(getCurrentDirname()),<br>
+ LangTag, DBuilder.createFile(remapDIPath(MainFileName),<br>
+ remapDIPath(getCurrentDirname())),<br>
Producer, LO.Optimize, CGM.getCodeGenOpts().DwarfDebugFlags, RuntimeVers,<br>
CGM.getCodeGenOpts().SplitDwarfFile, EmissionKind, 0 /* DWOid */,<br>
CGM.getCodeGenOpts().SplitDwarfInlining);<br>
@@ -1977,10 +1978,11 @@<br>
// but LLVM detects skeleton CUs by looking for a non-zero DWO id.<br>
uint64_t Signature = Mod.getSignature() ? Mod.getSignature() : ~1ULL;<br>
llvm::DIBuilder DIB(CGM.getModule());<br>
- DIB.createCompileUnit(TheCU->getSourceLanguage(), Mod.getModuleName(),<br>
- Mod.getPath(), TheCU->getProducer(), true,<br>
- StringRef(), 0, Mod.getASTFile(),<br>
- llvm::DICompileUnit::FullDebug, Signature);<br>
+ DIB.createCompileUnit(TheCU->getSourceLanguage(),<br>
+ DIB.createFile(Mod.getModuleName(), Mod.getPath()),<br>
+ TheCU->getProducer(), true, StringRef(), 0,<br>
+ Mod.getASTFile(), llvm::DICompileUnit::FullDebug,<br>
+ Signature);<br>
DIB.finalize();<br>
}<br>
llvm::DIModule *Parent =<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
<p>---------------------------------------------------------------------<br>
Intel Israel (74) Limited</p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</p></body>
</html>