<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Reverted by 290130. I have new comments from Aleksei in <a href="https://reviews.llvm.org/D27180" class="">https://reviews.llvm.org/D27180</a>. I'll apply those and update the patch. <div class=""><br class=""></div><div class="">Sean</div><div class=""><br class=""></div><div class=""><div><blockquote type="cite" class=""><div class="">On Dec 19, 2016, at 9:48 AM, Sean Callanan <<a href="mailto:scallanan@apple.com" class="">scallanan@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">David,</div><div class=""><br class=""></div><div class="">thanks for keeping an eye on this and sorry for the breach of process.</div><div class="">Would having Vassil approve the changelist (<a href="https://reviews.llvm.org/D27180" class="">https://reviews.llvm.org/D27180</a>) be appropriate?</div><div class="">Let's say if he has any concerns or can't get to it by tomorrow, we revert my patches since they're pretty self-contained.</div><div class=""><br class=""></div><div class="">Sean</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class=""><div class="">On Dec 19, 2016, at 8:55 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Dec 15, 2016 at 2:18 PM Sean Callanan via Phabricator via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">spyffe updated this revision to Diff 81661.<br class="gmail_msg">spyffe marked 2 inline comments as done.<br class="gmail_msg">spyffe added a comment.<br class="gmail_msg">Herald added a subscriber: jgosnell.<br class="gmail_msg"><br class="gmail_msg">Applied Vassil and Vedant's comments. I will commit this soon.<br class="gmail_msg"></blockquote><div class=""><br class=""></div><div class="">Was this change approved/accepted by anyone? "commit if no one has objections in <time frame>" isn't generally how LLVM project changes are reviewed/committed.</div><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><br class="gmail_msg"><br class="gmail_msg">Repository:<br class="gmail_msg"> <span class="Apple-converted-space"> </span>rL LLVM<br class="gmail_msg"><br class="gmail_msg"><a href="https://reviews.llvm.org/D27180" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D27180</a><br class="gmail_msg"><br class="gmail_msg">Files:<br class="gmail_msg"> <span class="Apple-converted-space"> </span>test/Import/clang-flags/Inputs/S.c<br class="gmail_msg"> <span class="Apple-converted-space"> </span>test/Import/clang-flags/test.c<br class="gmail_msg"> <span class="Apple-converted-space"> </span>test/Import/empty-struct/Inputs/S.c<br class="gmail_msg"> <span class="Apple-converted-space"> </span>test/Import/empty-struct/test.c<br class="gmail_msg"> <span class="Apple-converted-space"> </span>test/Import/error-in-expression/Inputs/S.c<br class="gmail_msg"> <span class="Apple-converted-space"> </span>test/Import/error-in-expression/test.c<br class="gmail_msg"> <span class="Apple-converted-space"> </span>test/Import/error-in-import/Inputs/S.c<br class="gmail_msg"> <span class="Apple-converted-space"> </span>test/Import/error-in-import/test.c<br class="gmail_msg"> <span class="Apple-converted-space"> </span>test/Import/missing-import/test.c<br class="gmail_msg"> <span class="Apple-converted-space"> </span>tools/CMakeLists.txt<br class="gmail_msg"> <span class="Apple-converted-space"> </span>tools/clang-import-test/CMakeLists.txt<br class="gmail_msg"> <span class="Apple-converted-space"> </span>tools/clang-import-test/clang-import-test.cpp<br class="gmail_msg"><br class="gmail_msg">_______________________________________________<br class="gmail_msg">cfe-commits mailing list<br class="gmail_msg"><a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a></blockquote></div></div></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></body></html>