<div dir="ltr">Ah, sure - no worries. Good to mention/link to the other change, etc, in the future. (if the changes on the clang side are trivial enough to not need review, may not need to send them out for review either - or could include them as an addendum to the llvm change ("oh, and here's what it looks like in terms of client (clang) changes" sort of thing) - either in comments, as a link to a review that doesn't have other subscribers (so it doesn't go to cfe-commits), or as an attached patch to the llvm review, etc)</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 19, 2016 at 9:05 AM Aboud, Amjad <<a href="mailto:amjad.aboud@intel.com">amjad.aboud@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple" class="gmail_msg">
<div class="m_3925359924683842176WordSection1 gmail_msg">
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg">It was approved by Reid.<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg">This patch had two parts, he did not stamp the change in Clang, but he did stamp the change for LLVM.<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg"><a href="https://reviews.llvm.org/D27762" class="gmail_msg" target="_blank">https://reviews.llvm.org/D27762</a><u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg">I assumed that this means a green light to commit.<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg">Did I misinterpret the rules?<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg">Thanks,<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg">Amjad<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><a name="m_3925359924683842176__MailEndCompose" class="gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt" class="gmail_msg">
<div class="gmail_msg">
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in" class="gmail_msg">
<p class="MsoNormal gmail_msg"><a name="m_3925359924683842176______replyseparator" class="gmail_msg"></a><b class="gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif" class="gmail_msg">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif" class="gmail_msg"> David Blaikie [mailto:<a href="mailto:dblaikie@gmail.com" class="gmail_msg" target="_blank">dblaikie@gmail.com</a>]
<br class="gmail_msg">
<b class="gmail_msg">Sent:</b> Monday, December 19, 2016 19:00<br class="gmail_msg">
<b class="gmail_msg">To:</b> <a href="mailto:reviews%2BD27763%2Bpublic%2B4530ee00cad2817d@reviews.llvm.org" class="gmail_msg" target="_blank">reviews+D27763+public+4530ee00cad2817d@reviews.llvm.org</a>; Amjad Aboud via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="gmail_msg" target="_blank">reviews@reviews.llvm.org</a>>; Aboud, Amjad <<a href="mailto:amjad.aboud@intel.com" class="gmail_msg" target="_blank">amjad.aboud@intel.com</a>>; <a href="mailto:rnk@google.com" class="gmail_msg" target="_blank">rnk@google.com</a><br class="gmail_msg">
<b class="gmail_msg">Cc:</b> <a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<b class="gmail_msg">Subject:</b> Re: [PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
</div>
</div></div></div></div><div lang="EN-US" link="blue" vlink="purple" class="gmail_msg"><div class="m_3925359924683842176WordSection1 gmail_msg"><div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt" class="gmail_msg">
<p class="MsoNormal gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></p>
<div class="gmail_msg">
<p class="MsoNormal gmail_msg">Was this change approved by anyone? Generally once it's sent for review, you should wait until it's approved before committing (the assumption being, if you sent it for review it's because it needed review)<u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</div>
<p class="MsoNormal gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></p>
<div class="gmail_msg">
<div class="gmail_msg">
<p class="MsoNormal gmail_msg">On Wed, Dec 14, 2016 at 12:49 PM Amjad Aboud via Phabricator via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in" class="gmail_msg">
<p class="MsoNormal gmail_msg">This revision was automatically updated to reflect the committed changes.<br class="gmail_msg">
Closed by commit rL289701: [DebugInfo] Changed DIBuilder::createCompileUnit() to take DIFile instead of… (authored by aaboud).<br class="gmail_msg">
<br class="gmail_msg">
Changed prior to commit:<br class="gmail_msg">
<a href="https://reviews.llvm.org/D27763?vs=81397&id=81438#toc" class="gmail_msg" target="_blank">
https://reviews.llvm.org/D27763?vs=81397&id=81438#toc</a><br class="gmail_msg">
<br class="gmail_msg">
Repository:<br class="gmail_msg">
rL LLVM<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D27763" class="gmail_msg" target="_blank">https://reviews.llvm.org/D27763</a><br class="gmail_msg">
<br class="gmail_msg">
Files:<br class="gmail_msg">
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Index: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br class="gmail_msg">
===================================================================<br class="gmail_msg">
--- cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br class="gmail_msg">
+++ cfe/trunk/lib/CodeGen/CGDebugInfo.cpp<br class="gmail_msg">
@@ -466,7 +466,8 @@<br class="gmail_msg">
// Create new compile unit.<br class="gmail_msg">
// FIXME - Eliminate TheCU.<br class="gmail_msg">
TheCU = DBuilder.createCompileUnit(<br class="gmail_msg">
- LangTag, remapDIPath(MainFileName), remapDIPath(getCurrentDirname()),<br class="gmail_msg">
+ LangTag, DBuilder.createFile(remapDIPath(MainFileName),<br class="gmail_msg">
+ remapDIPath(getCurrentDirname())),<br class="gmail_msg">
Producer, LO.Optimize, CGM.getCodeGenOpts().DwarfDebugFlags, RuntimeVers,<br class="gmail_msg">
CGM.getCodeGenOpts().SplitDwarfFile, EmissionKind, 0 /* DWOid */,<br class="gmail_msg">
CGM.getCodeGenOpts().SplitDwarfInlining);<br class="gmail_msg">
@@ -1977,10 +1978,11 @@<br class="gmail_msg">
// but LLVM detects skeleton CUs by looking for a non-zero DWO id.<br class="gmail_msg">
uint64_t Signature = Mod.getSignature() ? Mod.getSignature() : ~1ULL;<br class="gmail_msg">
llvm::DIBuilder DIB(CGM.getModule());<br class="gmail_msg">
- DIB.createCompileUnit(TheCU->getSourceLanguage(), Mod.getModuleName(),<br class="gmail_msg">
- Mod.getPath(), TheCU->getProducer(), true,<br class="gmail_msg">
- StringRef(), 0, Mod.getASTFile(),<br class="gmail_msg">
- llvm::DICompileUnit::FullDebug, Signature);<br class="gmail_msg">
+ DIB.createCompileUnit(TheCU->getSourceLanguage(),<br class="gmail_msg">
+ DIB.createFile(Mod.getModuleName(), Mod.getPath()),<br class="gmail_msg">
+ TheCU->getProducer(), true, StringRef(), 0,<br class="gmail_msg">
+ Mod.getASTFile(), llvm::DICompileUnit::FullDebug,<br class="gmail_msg">
+ Signature);<br class="gmail_msg">
DIB.finalize();<br class="gmail_msg">
}<br class="gmail_msg">
llvm::DIModule *Parent =<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</blockquote>
</div>
</div></div></div><div lang="EN-US" link="blue" vlink="purple" class="gmail_msg"><div class="m_3925359924683842176WordSection1 gmail_msg"><div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt" class="gmail_msg"></div>
</div>
<p class="gmail_msg">---------------------------------------------------------------------<br class="gmail_msg">
Intel Israel (74) Limited</p>
<p class="gmail_msg">This e-mail and any attachments may contain confidential material for<br class="gmail_msg">
the sole use of the intended recipient(s). Any review or distribution<br class="gmail_msg">
by others is strictly prohibited. If you are not the intended<br class="gmail_msg">
recipient, please contact the sender and delete all copies.</p></div>
</blockquote></div>