<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Dec 16, 2016 at 12:21 AM, Akira Hatanaka <span dir="ltr"><<a href="mailto:ahatanaka@apple.com" target="_blank">ahatanaka@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span class=""><blockquote type="cite"><div>On Dec 15, 2016, at 9:18 PM, Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>> wrote:</div><br class="m_7076064349276801785Apple-interchange-newline"><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_extra"><div class="gmail_quote">On Fri, Dec 16, 2016 at 12:14 AM, Akira Hatanaka<span class="m_7076064349276801785Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:ahatanaka@apple.com" target="_blank">ahatanaka@apple.com</a>></span><span class="m_7076064349276801785Apple-converted-space"><wbr> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><span><blockquote type="cite"><div>On Dec 15, 2016, at 9:08 PM, Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>> wrote:</div><br class="m_7076064349276801785m_-6329057647568170800Apple-interchange-newline"><div><div dir="ltr">I think the problem was that you didn't pipe the output to /dev/null or -, and so a .ll file got created which now confuses the bots.<div><br></div><div>I suggest:</div><div>1. Add `// RUN: rm -f right_path.ll` at the top for a while (look through magic lit vars to find one that expands to the right thing)</div><div>2. If the intent for this is to be a -verify check, add that back</div><div>3. If not, remove expected-no-diagnostics</div><div>4. If not, is this a FileCheck test? If so, pipe output to FileCheck, add CHECK lines</div><div>5. If it isn't FileCheck either, what does this test?</div></div><div class="gmail_extra"><br></div></div></blockquote><div><br></div></span>I intended to do IRGen because that was where it was crashing.</div></div></blockquote><div><br></div><div>Then the test should probably be somewhere in test/CodeGenCXX and FileCheck that the generated IR looks mostly correct :-)</div><div> </div></div></div></div></div></blockquote><div><br></div></span><div>Yes, I think the test should FileCheck the IR. The bugs I fixed are in Sema, however the crash occurs in IRGen. In that case, should the test go to CodeGen* or Sema*? I see several tests in SemaTemplate are generating IR (using -emit-llvm).</div></div></div></blockquote><div><br></div><div>Hm, I guess it's fine to keep it here then. (I find this surprising, though.)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><div class="h5"><br><blockquote type="cite"><div><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div class="m_7076064349276801785h5"><div><br><blockquote type="cite"><div><div class="gmail_extra"><div class="gmail_quote">On Fri, Dec 16, 2016 at 12:05 AM, Nico Weber<span class="m_7076064349276801785Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span><span class="m_7076064349276801785Apple-converted-space"> </span>wr<wbr>ote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Are you aware that this is still failing on all the bots? (<a href="http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/493" target="_blank">http://lab.llvm.org:8011/buil<wbr>ders/clang-atom-d525-fedora-re<wbr>l/builds/493</a><span class="m_7076064349276801785Apple-converted-space"> </span>eg)</div><div class="m_7076064349276801785m_-6329057647568170800HOEnZb"><div class="m_7076064349276801785m_-6329057647568170800h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 15, 2016 at 11:18 PM, Akira Hatanaka via cfe-commits<span class="m_7076064349276801785Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@<wbr>lists.llvm.org</a>></span><span class="m_7076064349276801785Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: ahatanak<br>Date: Thu Dec 15 22:18:53 2016<br>New Revision: 289919<br><br>URL:<span class="m_7076064349276801785Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=289919&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/<wbr>llvm-project?rev=289919&view=<wbr>rev</a><br>Log:<br>Remove "-disable-llvm-optzns -verify" from the RUN line.<br><br>Modified:<br>   <span class="m_7076064349276801785Apple-converted-space"> </span>cfe/trunk/test/SemaTemplate/<wbr>default-expr-arguments-3.cpp<br><br>Modified: cfe/trunk/test/SemaTemplate/de<wbr>fault-expr-arguments-3.cpp<br>URL:<span class="m_7076064349276801785Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaTemplate/default-expr-arguments-3.cpp?rev=289919&r1=289918&r2=289919&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/<wbr>llvm-project/cfe/trunk/test/<wbr>SemaTemplate/default-expr-<wbr>arguments-3.cpp?rev=289919&r1=<wbr>289918&r2=289919&view=diff</a><br>==============================<wbr>==============================<wbr>==================<br>--- cfe/trunk/test/SemaTemplate/de<wbr>fault-expr-arguments-3.cpp (original)<br>+++ cfe/trunk/test/SemaTemplate/de<wbr>fault-expr-arguments-3.cpp Thu Dec 15 22:18:53 2016<br>@@ -1,4 +1,4 @@<br>-// RUN: %clang_cc1 -std=c++14 -emit-llvm -disable-llvm-optzns -verify %s<br>+// RUN: %clang_cc1 -std=c++14 -emit-llvm -o - %s<br> // expected-no-diagnostics<br><br> namespace PR28795 {<br><br><br>______________________________<wbr>_________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a></blockquote></div></div></div></div></blockquote></div></div></div></blockquote></div></div></div></div></blockquote></div></div></div></div></blockquote></div></div></div><br></div></blockquote></div><br></div></div>