<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 15, 2016, at 9:18 PM, Nico Weber <<a href="mailto:thakis@chromium.org" class="">thakis@chromium.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_extra"><div class="gmail_quote">On Fri, Dec 16, 2016 at 12:14 AM, Akira Hatanaka<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:ahatanaka@apple.com" target="_blank" class="">ahatanaka@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;" class=""><br class=""><div class=""><span class=""><blockquote type="cite" class=""><div class="">On Dec 15, 2016, at 9:08 PM, Nico Weber <<a href="mailto:thakis@chromium.org" target="_blank" class="">thakis@chromium.org</a>> wrote:</div><br class="m_-6329057647568170800Apple-interchange-newline"><div class=""><div dir="ltr" class="">I think the problem was that you didn't pipe the output to /dev/null or -, and so a .ll file got created which now confuses the bots.<div class=""><br class=""></div><div class="">I suggest:</div><div class="">1. Add `// RUN: rm -f right_path.ll` at the top for a while (look through magic lit vars to find one that expands to the right thing)</div><div class="">2. If the intent for this is to be a -verify check, add that back</div><div class="">3. If not, remove expected-no-diagnostics</div><div class="">4. If not, is this a FileCheck test? If so, pipe output to FileCheck, add CHECK lines</div><div class="">5. If it isn't FileCheck either, what does this test?</div></div><div class="gmail_extra"><br class=""></div></div></blockquote><div class=""><br class=""></div></span>I intended to do IRGen because that was where it was crashing.</div></div></blockquote><div class=""><br class=""></div><div class="">Then the test should probably be somewhere in test/CodeGenCXX and FileCheck that the generated IR looks mostly correct :-)</div><div class=""> </div></div></div></div></div></blockquote><div><br class=""></div><div>Yes, I think the test should FileCheck the IR. The bugs I fixed are in Sema, however the crash occurs in IRGen. In that case, should the test go to CodeGen* or Sema*? I see several tests in SemaTemplate are generating IR (using -emit-llvm).</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;" class=""><div class=""><div class="h5"><div class=""><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_extra"><div class="gmail_quote">On Fri, Dec 16, 2016 at 12:05 AM, Nico Weber<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:thakis@chromium.org" target="_blank" class="">thakis@chromium.org</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div dir="ltr" class="">Are you aware that this is still failing on all the bots? (<a href="http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/493" target="_blank" class="">http://lab.llvm.org:8011/buil<wbr class="">ders/clang-atom-d525-fedora-<wbr class="">rel/builds/493</a><span class="Apple-converted-space"> </span>eg)</div><div class="m_-6329057647568170800HOEnZb"><div class="m_-6329057647568170800h5"><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Dec 15, 2016 at 11:18 PM, Akira Hatanaka via cfe-commits<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">Author: ahatanak<br class="">Date: Thu Dec 15 22:18:53 2016<br class="">New Revision: 289919<br class=""><br class="">URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=289919&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-pr<wbr class="">oject?rev=289919&view=rev</a><br class="">Log:<br class="">Remove "-disable-llvm-optzns -verify" from the RUN line.<br class=""><br class="">Modified:<br class=""> <span class="Apple-converted-space"> </span>cfe/trunk/test/SemaTemplate/de<wbr class="">fault-expr-arguments-3.cpp<br class=""><br class="">Modified: cfe/trunk/test/SemaTemplate/de<wbr class="">fault-expr-arguments-3.cpp<br class="">URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaTemplate/default-expr-arguments-3.cpp?rev=289919&r1=289918&r2=289919&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-pr<wbr class="">oject/cfe/trunk/test/SemaTempl<wbr class="">ate/default-expr-arguments-3.c<wbr class="">pp?rev=289919&r1=289918&r2=289<wbr class="">919&view=diff</a><br class="">==============================<wbr class="">==============================<wbr class="">==================<br class="">--- cfe/trunk/test/SemaTemplate/de<wbr class="">fault-expr-arguments-3.cpp (original)<br class="">+++ cfe/trunk/test/SemaTemplate/de<wbr class="">fault-expr-arguments-3.cpp Thu Dec 15 22:18:53 2016<br class="">@@ -1,4 +1,4 @@<br class="">-// RUN: %clang_cc1 -std=c++14 -emit-llvm -disable-llvm-optzns -verify %s<br class="">+// RUN: %clang_cc1 -std=c++14 -emit-llvm -o - %s<br class=""> // expected-no-diagnostics<br class=""><br class=""> namespace PR28795 {<br class=""><br class=""><br class="">______________________________<wbr class="">_________________<br class="">cfe-commits mailing list<br class=""><a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/cfe-commits</a></blockquote></div></div></div></div></blockquote></div></div></div></blockquote></div></div></div></div></blockquote></div></div></div></div></blockquote></div><br class=""></body></html>