<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 12, 2016 at 1:11 PM David Gross <<a href="mailto:dgross@google.com">dgross@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">I looked at what's supported by "requires", and couldn't find anything appropriate.<div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">The problem is that I want the test to be sensitive to the size of long double -- either no greater than 64 bits, or greater than 64 bits. It does not seem practical to list all platforms (so I suspect your "xfail" suggestion would not be suitable). I'd like to find some way to make the determination programmatically in the test suite. It's certainly possible that the answer is that there's no good way to do it.</div></div></blockquote><div><br></div><div>I doubt there's a good way to do that.<br><br>I'd probably just write it for one target (I assume this is the case on x86? A pretty good/stable/ubiquitous target - and we have a lot of DWARF test coverage that's x86-only) and move on.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Mon, Dec 12, 2016 at 11:31 AM, David Blaikie <span dir="ltr" class="gmail_msg"><<a href="mailto:dblaikie@gmail.com" class="gmail_msg" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">While it's possible to do arbitrary script things - we prefer nto to to ensure the tests are portable. (we have some custom implementations of common unix utilities for portability of those).<br class="gmail_msg"><br class="gmail_msg">In this case, can you xfail this on platforms that don't have the feature you want? rather than trying to detect it at test-execution time. (or say "requires" to opt the test in only on platforms you know have the thing you want)</div><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div class="gmail_msg"><div class="m_1143739885751893637h5 gmail_msg"><div dir="ltr" class="gmail_msg">On Fri, Dec 9, 2016 at 4:00 AM David Gross via Phabricator via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg"></div></div></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_msg"><div class="m_1143739885751893637h5 gmail_msg">dgross added a comment.<br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
<br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
I don't know exactly what the RUN syntax supported by lit is. What I've done here looks complex, but it does work for Linux. What about other platforms?<br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
<br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
Is there some better way of writing a test case where the checks to be done by FileCheck depend on some property of the file being analyzed (here, the size of long double, as embedded in the debug metadata)? I don't see any support for conditions in FileCheck.<br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
<br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
Maybe I'm going about this completely the wrong way?<br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
<br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
<br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
<a href="https://reviews.llvm.org/D27597" rel="noreferrer" class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg" target="_blank">https://reviews.llvm.org/D27597</a><br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
<br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
<br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
<br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg"></div></div>
_______________________________________________<br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
cfe-commits mailing list<br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="m_1143739885751893637m_3575438995367613866gmail_msg gmail_msg">
</blockquote></div>
</blockquote></div><br class="gmail_msg"></div>
</blockquote></div></div>