<div dir="ltr">Hi Malcolm,<div><br></div><div>I will look into fixing the two cases only. </div><div>argumentCountIs(1) is sufficient to narrow the matching to only string compare with one argument.</div><div><br></div><div>Best regards,</div><div>Mads Ravn</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 12, 2016 at 10:38 AM Malcolm Parsons via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">malcolm.parsons added inline comments.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
================<br class="gmail_msg">
Comment at: clang-tidy/misc/StringCompareCheck.cpp:25<br class="gmail_msg">
+      callee(cxxMethodDecl(hasName("compare"),<br class="gmail_msg">
+                           ofClass(classTemplateSpecializationDecl(<br class="gmail_msg">
+                               hasName("::std::basic_string"))))),<br class="gmail_msg">
----------------<br class="gmail_msg">
malcolm.parsons wrote:<br class="gmail_msg">
> malcolm.parsons wrote:<br class="gmail_msg">
> > This needs to check that it's one of the single parameter overloads of compare.<br class="gmail_msg">
> Add `parameterCountIs(1)`.<br class="gmail_msg">
Actually, the `argumentCountIs(1)` below should be sufficient.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D27210" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D27210</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>