<div dir="ltr">Hi guys,<div><br></div><div>Do you have any extra comments for this?</div><div><br></div><div>Best regards</div></div><br><div class="gmail_quote"><div dir="ltr">On Sat, Dec 3, 2016 at 1:34 PM Mads Ravn via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">madsravn updated this revision to Diff 80177.<br class="gmail_msg">
madsravn added a comment.<br class="gmail_msg">
<br class="gmail_msg">
Did as comments suggested: Fixed the description about compare returning -1, 0 or 1. Fixed the ast matcher to only find compare with one argument. Clang-formatted everything. Added a new test (str.compare("foo")) and wrote a FIXME for the fixit.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D27210" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D27210</a><br class="gmail_msg">
<br class="gmail_msg">
Files:<br class="gmail_msg">
  clang-tidy/misc/CMakeLists.txt<br class="gmail_msg">
  clang-tidy/misc/MiscTidyModule.cpp<br class="gmail_msg">
  clang-tidy/misc/StringCompareCheck.cpp<br class="gmail_msg">
  clang-tidy/misc/StringCompareCheck.h<br class="gmail_msg">
  docs/ReleaseNotes.rst<br class="gmail_msg">
  docs/clang-tidy/checks/list.rst<br class="gmail_msg">
  docs/clang-tidy/checks/misc-string-compare.rst<br class="gmail_msg">
  test/clang-tidy/misc-string-compare.cpp<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>