<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 6 December 2016 at 19:39, Vitaly Buka <span dir="ltr"><<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div dir="ltr" class="gmail-m_-4437944731714362100gmail_msg"><div class="gmail-m_-4437944731714362100gmail_msg"><div class="gmail-m_-4437944731714362100gmail_msg">Hi Alex, </div><span class="gmail-"><div class="gmail-m_-4437944731714362100gmail_msg"><br></div><div class="gmail-m_-4437944731714362100gmail_msg"><br></div><div class="gmail-m_-4437944731714362100gmail_msg"><br></div><div class="gmail-m_-4437944731714362100gmail_msg"><div class="gmail-m_-4437944731714362100gmail_msg">On Tue, Dec 6, 2016 at 11:14 AM Alex L <<a href="mailto:arphaman@gmail.com" class="gmail-m_-4437944731714362100gmail_msg gmail-m_-4437944731714362100cremed" target="_blank">arphaman@gmail.com</a>> wrote:<br></div></div></span></div></div><div class="gmail_quote gmail-m_-4437944731714362100gmail_msg"><span class="gmail-"><blockquote class="gmail_quote gmail-m_-4437944731714362100gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr" class="gmail-m_-4437944731714362100gmail_msg">Hi Vitaly,<div class="gmail-m_-4437944731714362100gmail_msg"><br class="gmail-m_-4437944731714362100gmail_msg"></div><div class="gmail-m_-4437944731714362100gmail_msg">I noticed that you posted this patch up for review at <a href="https://reviews.llvm.org/D27422" rel="noreferrer" style="font-size:12.800000190734863px" class="gmail-m_-4437944731714362100gmail_msg gmail-m_-4437944731714362100cremed" target="_blank">https://reviews.llvm.org/<wbr>D27422</a>, but then committed it instantly without waiting for approval (and you did the same for r288685 as well). Is there any particular reason why you did this? I think that you should've waited for approval before committing. </div></div></blockquote></span><div><div class="gmail-m_-4437944731714362100gmail_msg"><br></div><div class="gmail-m_-4437944731714362100gmail_msg">We had broken build bots, so seem like this trivial change is better than reverting patches.</div><div class="gmail-m_-4437944731714362100gmail_msg">No.3 of <a href="http://llvm.org/docs/DeveloperPolicy.html#code-reviews" class="gmail-m_-4437944731714362100inbox-inbox-inbox-inbox-m_-1283377154847223513cremed gmail-m_-4437944731714362100gmail_msg gmail-m_-4437944731714362100inbox-inbox-inbox-inbox-cremed gmail-m_-4437944731714362100inbox-inbox-cremed gmail-m_-4437944731714362100cremed" target="_blank">http://llvm.org/docs/<wbr>DeveloperPolicy.html#code-<wbr>reviews</a> allows after commit review for changes like this.</div></div></div></div></blockquote><div><br></div><div>Thanks for the clarification. Yes, the developer policy states that you can commit small changes and get them reviewed after committing, so a commit like this would've been perfect for a post-commit review. However, it also says that "Specifically, once a patch is sent out for review, it needs an explicit “looks good” before it is submitted". Please avoid submitting patches for review if you know that you will commit them without waiting for approval in the future.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote gmail-m_-4437944731714362100gmail_msg"><span class="gmail-"><div> </div><blockquote class="gmail_quote gmail-m_-4437944731714362100gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr" class="gmail-m_-4437944731714362100gmail_msg"><div class="gmail-m_-4437944731714362100gmail_msg">This patch is pretty small, and so it looks to me like it could have been reviewed after it was committed, but patches that get post-commit reviews shouldn't get explicit review requests like this one did.</div></div></blockquote><div><br></div></span><div>Sorry, probably I did the same few time before. I can't find exact details in the policy, but I assumed that was a reasonable approach.</div><div>So what is the process for after commit review?<br></div></div></div></blockquote><div><br></div><div>People usually read the commit logs and check which commits need post-commit reviews, and then look at them. There's no need for an explicit review request for commits like this.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_quote gmail-m_-4437944731714362100gmail_msg"><div></div><div><div class="gmail-h5"><div> </div><blockquote class="gmail_quote gmail-m_-4437944731714362100gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr" class="gmail-m_-4437944731714362100gmail_msg"><div class="gmail-m_-4437944731714362100gmail_msg"><br class="gmail-m_-4437944731714362100gmail_msg"></div><div class="gmail-m_-4437944731714362100gmail_msg">Alex</div></div><div class="gmail_extra gmail-m_-4437944731714362100gmail_msg"><br class="gmail-m_-4437944731714362100gmail_msg"><div class="gmail_quote gmail-m_-4437944731714362100gmail_msg">On 5 December 2016 at 19:25, Vitaly Buka via cfe-commits <span dir="ltr" class="gmail-m_-4437944731714362100gmail_msg"><<a href="mailto:cfe-commits@lists.llvm.org" class="gmail-m_-4437944731714362100gmail_msg gmail-m_-4437944731714362100cremed" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br class="gmail-m_-4437944731714362100gmail_msg"><blockquote class="gmail_quote gmail-m_-4437944731714362100gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: vitalybuka<br class="gmail-m_-4437944731714362100gmail_msg">
Date: Mon Dec 5 13:25:00 2016<br class="gmail-m_-4437944731714362100gmail_msg">
New Revision: 288689<br class="gmail-m_-4437944731714362100gmail_msg">
<br class="gmail-m_-4437944731714362100gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=288689&view=rev" rel="noreferrer" class="gmail-m_-4437944731714362100gmail_msg gmail-m_-4437944731714362100cremed" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=288689&view=rev</a><br class="gmail-m_-4437944731714362100gmail_msg">
Log:<br class="gmail-m_-4437944731714362100gmail_msg">
Fix stack-use-after-scope in CheckExplicitlyDefaultedMember<wbr>ExceptionSpec<br class="gmail-m_-4437944731714362100gmail_msg">
<br class="gmail-m_-4437944731714362100gmail_msg">
Summary:<br class="gmail-m_-4437944731714362100gmail_msg">
Similar to r288685.<br class="gmail-m_-4437944731714362100gmail_msg">
getExceptionSpec returned structure with pointers to temporarily object created<br class="gmail-m_-4437944731714362100gmail_msg">
by computeImplicitExceptionSpec.<br class="gmail-m_-4437944731714362100gmail_msg">
<br class="gmail-m_-4437944731714362100gmail_msg">
Reviewers: rsmith<br class="gmail-m_-4437944731714362100gmail_msg">
<br class="gmail-m_-4437944731714362100gmail_msg">
Subscribers: aizatsky, cfe-commits<br class="gmail-m_-4437944731714362100gmail_msg">
<br class="gmail-m_-4437944731714362100gmail_msg">
Differential Revision: <a href="https://reviews.llvm.org/D27422" rel="noreferrer" class="gmail-m_-4437944731714362100gmail_msg gmail-m_-4437944731714362100cremed" target="_blank">https://reviews.llvm.org/<wbr>D27422</a><br class="gmail-m_-4437944731714362100gmail_msg">
<br class="gmail-m_-4437944731714362100gmail_msg">
Modified:<br class="gmail-m_-4437944731714362100gmail_msg">
cfe/trunk/lib/Sema/<wbr>SemaDeclCXX.cpp<br class="gmail-m_-4437944731714362100gmail_msg">
<br class="gmail-m_-4437944731714362100gmail_msg">
Modified: cfe/trunk/lib/Sema/<wbr>SemaDeclCXX.cpp<br class="gmail-m_-4437944731714362100gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclCXX.cpp?rev=288689&r1=288688&r2=288689&view=diff" rel="noreferrer" class="gmail-m_-4437944731714362100gmail_msg gmail-m_-4437944731714362100cremed" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/Sema/<wbr>SemaDeclCXX.cpp?rev=288689&r1=<wbr>288688&r2=288689&view=diff</a><br class="gmail-m_-4437944731714362100gmail_msg">
==============================<wbr>==============================<wbr>==================<br class="gmail-m_-4437944731714362100gmail_msg">
--- cfe/trunk/lib/Sema/<wbr>SemaDeclCXX.cpp (original)<br class="gmail-m_-4437944731714362100gmail_msg">
+++ cfe/trunk/lib/Sema/<wbr>SemaDeclCXX.cpp Mon Dec 5 13:25:00 2016<br class="gmail-m_-4437944731714362100gmail_msg">
@@ -6299,8 +6299,8 @@ void Sema::<wbr>CheckExplicitlyDefaultedMembe<br class="gmail-m_-4437944731714362100gmail_msg">
CallingConv CC = Context.<wbr>getDefaultCallingConvention(/*<wbr>IsVariadic=*/false,<br class="gmail-m_-4437944731714362100gmail_msg">
/*IsCXXMethod=*/true);<br class="gmail-m_-4437944731714362100gmail_msg">
FunctionProtoType::<wbr>ExtProtoInfo EPI(CC);<br class="gmail-m_-4437944731714362100gmail_msg">
- EPI.ExceptionSpec = computeImplicitExceptionSpec(*<wbr>this, MD->getLocation(), MD)<br class="gmail-m_-4437944731714362100gmail_msg">
- .getExceptionSpec();<br class="gmail-m_-4437944731714362100gmail_msg">
+ auto IES = computeImplicitExceptionSpec(*<wbr>this, MD->getLocation(), MD);<br class="gmail-m_-4437944731714362100gmail_msg">
+ EPI.ExceptionSpec = IES.getExceptionSpec();<br class="gmail-m_-4437944731714362100gmail_msg">
const FunctionProtoType *ImplicitType = cast<FunctionProtoType>(<br class="gmail-m_-4437944731714362100gmail_msg">
Context.getFunctionType(<wbr>Context.VoidTy, None, EPI));<br class="gmail-m_-4437944731714362100gmail_msg">
<br class="gmail-m_-4437944731714362100gmail_msg">
<br class="gmail-m_-4437944731714362100gmail_msg">
<br class="gmail-m_-4437944731714362100gmail_msg">
______________________________<wbr>_________________<br class="gmail-m_-4437944731714362100gmail_msg">
cfe-commits mailing list<br class="gmail-m_-4437944731714362100gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail-m_-4437944731714362100gmail_msg gmail-m_-4437944731714362100cremed" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail-m_-4437944731714362100gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail-m_-4437944731714362100gmail_msg gmail-m_-4437944731714362100cremed" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br class="gmail-m_-4437944731714362100gmail_msg">
</blockquote></div><br class="gmail-m_-4437944731714362100gmail_msg"></div>
</blockquote></div></div></div></div>
</blockquote></div><br></div></div>