<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 7 December 2016 at 10:11, Malcolm Parsons <span dir="ltr"><<a href="mailto:malcolm.parsons@gmail.com" target="_blank">malcolm.parsons@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 7 December 2016 at 17:56, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:<br>
> On 7 Dec 2016 9:49 am, "Malcolm Parsons via cfe-commits"<br>
> <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: malcolm.parsons<br>
> Date: Wed Dec  7 11:39:04 2016<br>
> New Revision: 288923<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=288923&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=288923&view=rev</a><br>
> Log:<br>
> [RecursiveASTVisitor] Fix post-order traversal of UnaryOperator<br>
><br>
> Reviewers: aaron.ballman, klimek, doug.gregor, teemperor, rsmith<br>
><br>
> Subscribers: cfe-commits<br>
><br>
> Differential Revision: <a href="https://reviews.llvm.org/D26742" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D26742</a><br>
><br>
</span><span class="">> @@ -87,7 +92,7 @@ TEST(RecursiveASTVisitor, PostOrderTrave<br>
>    Visitor.<wbr>TraverseTranslationUnitDecl(<wbr>TU);<br>
><br>
>    std::vector<std::string> expected = {<br>
> -    "4", "9", "i", "1", "3", "+", "2", "+", "return", "A::B::foo", "A::B",<br>
> "A"<br>
> +    "4", "9", "i", "-",<br>
<br>
> Why does "i" not show up here twice? Do we not include DeclRefExprs in this<br>
> list? It looks like we're not testing the relative order of the unary<br>
> operator and its operand here.<br>
<br>
</span>The test doesn't define VisitDeclRefExpr.<br>
<br>
I can add it if you like.</blockquote><div><br></div><div>Perhaps a better approach would be to change the "-i" to "-5", so there's no ambiguity as to what "i" means in the expected output.</div></div></div></div>