<div dir="ltr"><div dir="ltr" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg">Hi Alex, </div><div class="gmail_msg"><br></div><div class="gmail_msg"><br></div><div class="gmail_msg"><br></div><div class="gmail_msg"><div class="gmail_msg">On Tue, Dec 6, 2016 at 11:14 AM Alex L <<a href="mailto:arphaman@gmail.com" class="gmail_msg cremed" target="_blank">arphaman@gmail.com</a>> wrote:<br></div></div></div></div><div class="gmail_quote gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Hi Vitaly,<div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">I noticed that you posted this patch up for review at <a href="https://reviews.llvm.org/D27422" rel="noreferrer" style="font-size:12.800000190734863px" class="gmail_msg cremed" target="_blank">https://reviews.llvm.org/D27422</a>, but then committed it instantly without waiting for approval (and you did the same for r288685 as well). Is there any particular reason why you did this? I think that you should've waited for approval before committing. </div></div></blockquote><div><div class="gmail_msg"><br></div><div class="gmail_msg">We had broken build bots, so seem like this trivial change is better than reverting patches.</div><div class="gmail_msg">No.3 of <a href="http://llvm.org/docs/DeveloperPolicy.html#code-reviews" class="inbox-inbox-inbox-inbox-m_-1283377154847223513cremed gmail_msg inbox-inbox-inbox-inbox-cremed inbox-inbox-cremed cremed" target="_blank">http://llvm.org/docs/DeveloperPolicy.html#code-reviews</a> allows after commit review for changes like this.</div></div><div> </div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_msg">This patch is pretty small, and so it looks to me like it could have been reviewed after it was committed, but patches that get post-commit reviews shouldn't get explicit review requests like this one did.</div></div></blockquote><div><br></div><div>Sorry, probably I did the same few time before. I can't find exact details in the policy, but I assumed that was a reasonable approach.</div><div>So what is the process for after commit review?<br></div><div> </div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Alex</div></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On 5 December 2016 at 19:25, Vitaly Buka via cfe-commits <span dir="ltr" class="gmail_msg"><<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg cremed" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: vitalybuka<br class="gmail_msg">
Date: Mon Dec 5 13:25:00 2016<br class="gmail_msg">
New Revision: 288689<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=288689&view=rev" rel="noreferrer" class="gmail_msg cremed" target="_blank">http://llvm.org/viewvc/llvm-project?rev=288689&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec<br class="gmail_msg">
<br class="gmail_msg">
Summary:<br class="gmail_msg">
Similar to r288685.<br class="gmail_msg">
getExceptionSpec returned structure with pointers to temporarily object created<br class="gmail_msg">
by computeImplicitExceptionSpec.<br class="gmail_msg">
<br class="gmail_msg">
Reviewers: rsmith<br class="gmail_msg">
<br class="gmail_msg">
Subscribers: aizatsky, cfe-commits<br class="gmail_msg">
<br class="gmail_msg">
Differential Revision: <a href="https://reviews.llvm.org/D27422" rel="noreferrer" class="gmail_msg cremed" target="_blank">https://reviews.llvm.org/D27422</a><br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
cfe/trunk/lib/Sema/SemaDeclCXX.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclCXX.cpp?rev=288689&r1=288688&r2=288689&view=diff" rel="noreferrer" class="gmail_msg cremed" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclCXX.cpp?rev=288689&r1=288688&r2=288689&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- cfe/trunk/lib/Sema/SemaDeclCXX.cpp (original)<br class="gmail_msg">
+++ cfe/trunk/lib/Sema/SemaDeclCXX.cpp Mon Dec 5 13:25:00 2016<br class="gmail_msg">
@@ -6299,8 +6299,8 @@ void Sema::CheckExplicitlyDefaultedMembe<br class="gmail_msg">
CallingConv CC = Context.getDefaultCallingConvention(/*IsVariadic=*/false,<br class="gmail_msg">
/*IsCXXMethod=*/true);<br class="gmail_msg">
FunctionProtoType::ExtProtoInfo EPI(CC);<br class="gmail_msg">
- EPI.ExceptionSpec = computeImplicitExceptionSpec(*this, MD->getLocation(), MD)<br class="gmail_msg">
- .getExceptionSpec();<br class="gmail_msg">
+ auto IES = computeImplicitExceptionSpec(*this, MD->getLocation(), MD);<br class="gmail_msg">
+ EPI.ExceptionSpec = IES.getExceptionSpec();<br class="gmail_msg">
const FunctionProtoType *ImplicitType = cast<FunctionProtoType>(<br class="gmail_msg">
Context.getFunctionType(Context.VoidTy, None, EPI));<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg cremed" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg cremed" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg">
</blockquote></div><br class="gmail_msg"></div>
</blockquote></div></div>