<div dir="ltr">Hi Vitaly,<div><br></div><div>I noticed that you posted this patch up for review at <a href="https://reviews.llvm.org/D27422" rel="noreferrer" style="font-size:12.800000190734863px" target="_blank">https://reviews.llvm.org/D2<wbr>7422</a>, but then committed it instantly without waiting for approval (and you did the same for r288685 as well). Is there any particular reason why you did this? I think that you should've waited for approval before committing. This patch is pretty small, and so it looks to me like it could have been reviewed after it was committed, but patches that get post-commit reviews shouldn't get explicit review requests like this one did.</div><div><br></div><div>Alex</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 5 December 2016 at 19:25, Vitaly Buka via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: vitalybuka<br>
Date: Mon Dec  5 13:25:00 2016<br>
New Revision: 288689<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=288689&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=288689&view=rev</a><br>
Log:<br>
Fix stack-use-after-scope in CheckExplicitlyDefaultedMember<wbr>ExceptionSpec<br>
<br>
Summary:<br>
Similar to r288685.<br>
getExceptionSpec returned structure with pointers to temporarily object created<br>
by computeImplicitExceptionSpec.<br>
<br>
Reviewers: rsmith<br>
<br>
Subscribers: aizatsky, cfe-commits<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D27422" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D27422</a><br>
<br>
Modified:<br>
    cfe/trunk/lib/Sema/<wbr>SemaDeclCXX.cpp<br>
<br>
Modified: cfe/trunk/lib/Sema/<wbr>SemaDeclCXX.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaDeclCXX.cpp?rev=288689&r1=288688&r2=288689&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/Sema/<wbr>SemaDeclCXX.cpp?rev=288689&r1=<wbr>288688&r2=288689&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- cfe/trunk/lib/Sema/<wbr>SemaDeclCXX.cpp (original)<br>
+++ cfe/trunk/lib/Sema/<wbr>SemaDeclCXX.cpp Mon Dec  5 13:25:00 2016<br>
@@ -6299,8 +6299,8 @@ void Sema::<wbr>CheckExplicitlyDefaultedMembe<br>
   CallingConv CC = Context.<wbr>getDefaultCallingConvention(/*<wbr>IsVariadic=*/false,<br>
                                                        /*IsCXXMethod=*/true);<br>
   FunctionProtoType::<wbr>ExtProtoInfo EPI(CC);<br>
-  EPI.ExceptionSpec = computeImplicitExceptionSpec(*<wbr>this, MD->getLocation(), MD)<br>
-                          .getExceptionSpec();<br>
+  auto IES = computeImplicitExceptionSpec(*<wbr>this, MD->getLocation(), MD);<br>
+  EPI.ExceptionSpec = IES.getExceptionSpec();<br>
   const FunctionProtoType *ImplicitType = cast<FunctionProtoType>(<br>
     Context.getFunctionType(<wbr>Context.VoidTy, None, EPI));<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>