<div dir="ltr">Ack. Will do in future.<div><br></div><div>Thanks Hal</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 2, 2016 at 3:54 PM, Hal Finkel <span dir="ltr"><<a href="mailto:hfinkel@anl.gov" target="_blank">hfinkel@anl.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">----- Original Message -----<br>
> From: "Eric Fiselier via cfe-commits" <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>><br>
> To: <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> Sent: Friday, December 2, 2016 4:30:53 PM<br>
> Subject: [libcxx] r288544 - Work around a bug in Clang's implementation of noexcept function types<br>
><br>
> Author: ericwf<br>
> Date: Fri Dec  2 16:30:52 2016<br>
> New Revision: 288544<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=288544&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=288544&view=rev</a><br>
> Log:<br>
> Work around a bug in Clang's implementation of noexcept function<br>
> types<br>
><br>
> Modified:<br>
>     libcxx/trunk/test/std/<wbr>utilities/meta/meta.rel/is_<wbr>nothrow_callable.pass.cpp<br>
><br>
> Modified:<br>
> libcxx/trunk/test/std/<wbr>utilities/meta/meta.rel/is_<wbr>nothrow_callable.pass.cpp<br>
> URL:<br>
> <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/utilities/meta/meta.rel/is_nothrow_callable.pass.cpp?rev=288544&r1=288543&r2=288544&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/test/std/<wbr>utilities/meta/meta.rel/is_<wbr>nothrow_callable.pass.cpp?rev=<wbr>288544&r1=288543&r2=288544&<wbr>view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> ---<br>
> libcxx/trunk/test/std/<wbr>utilities/meta/meta.rel/is_<wbr>nothrow_callable.pass.cpp<br>
> (original)<br>
> +++<br>
> libcxx/trunk/test/std/<wbr>utilities/meta/meta.rel/is_<wbr>nothrow_callable.pass.cpp<br>
> Fri Dec  2 16:30:52 2016<br>
> @@ -54,7 +54,11 @@ constexpr bool throws_callable() {<br>
>  void test_noexcept_function_<wbr>pointers()<br>
>  {<br>
>      struct Dummy { void foo() noexcept {} static void bar() noexcept<br>
>      {} };<br>
> -#if !defined(__cpp_noexcept_<wbr>function_type)<br>
> +<br>
> +// FIXME(EricWF): Remove the __clang__ workaround. As of 2/12/2016<br>
<br>
</div></div>As a general note, it is confusing to write dates this way. Most people in the US will read this as Feb. 12th, 2016. Others will read it as Dec. 2nd, 2016. I recommend using 2016-12-02 to avoid confusion.<br>
<span class="HOEnZb"><font color="#888888"><br>
 -Hal<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
> Clang has<br>
> +// a bug where calling a noexcept function pointer is not noexcept.<br>
> +// See <a href="https://llvm.org/bugs/show_bug.cgi?id=31244" rel="noreferrer" target="_blank">https://llvm.org/bugs/show_<wbr>bug.cgi?id=31244</a><br>
> +#if !defined(__cpp_noexcept_<wbr>function_type) || defined(__clang__)<br>
>      {<br>
>          // Check that PMF's and function pointers *work*.<br>
>          is_nothrow_callable will always<br>
>          // return false because 'noexcept' is not part of the<br>
>          function type.<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
><br>
</div></div></blockquote></div><br></div>