<div dir="ltr">Okay, I will keep it as a separate file then. It's very likely that I will soon send a follow up, as there's another very similar case known to not work properly (based on the experience with UBSan Vptr bot in Chromium)</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 15, 2016 at 6:27 PM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="">On Tue, Nov 15, 2016 at 6:20 PM, Ivan Krasin <span dir="ltr"><<a href="mailto:krasin@google.com" target="_blank">krasin@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thank you, Richard.<div><br></div><div>Shall I merge the newly introduced test/CodeGenCXX/ubs<wbr>an-vtable-checks.cpp into <span style="font-size:12.8px">catch-</span><span style="font-size:12.8px">undef-behavior.cpp or it's more clear when it's standalone?</span></div></div></blockquote><div><br></div></span><div>Up to you. catch-undef-behavior.cpp is getting unwieldy, so a separate test file doesn't seem like a bad thing.</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_1285145922131826351HOEnZb"><div class="m_1285145922131826351h5"><div class="gmail_extra"><div class="gmail_quote">On Tue, Nov 15, 2016 at 5:51 PM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span>On Fri, Nov 11, 2016 at 3:02 PM, Ivan Krasin via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">krasin added a comment.<br>
<br>
Small correction: all UBSan type checks tests live in compiler-rt.</blockquote><div><br></div></span><div>Actually, most of the UBSan tests live in test/CodeGenCXX/catch-undef<wbr>-behavior.cpp in Clang; the compiler-rt tests are merely aiming to test that the runtime produces the correct diagnostics. There are a few more test files testing UBSan besides that one; you can find the tests by grepping for "fsanitize=" in Clang's test/ directory.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>There is a test for UBsan + devirtualization inside tools/clang. My point still stands.<br>
</span><div class="m_1285145922131826351m_6604024676861581666m_8005098045476414021gmail-HOEnZb"><div class="m_1285145922131826351m_6604024676861581666m_8005098045476414021gmail-h5"><br>
<br>
<a href="https://reviews.llvm.org/D26559" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2655<wbr>9</a><br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div></div>
</blockquote></div><br></div>
</div></div></blockquote></span></div><br></div></div>
</blockquote></div><br></div>