<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Sun, Nov 13, 2016 at 1:30 PM Eric Fiselier via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">EricWF created this revision.<br class="gmail_msg">
EricWF added reviewers: mclow.lists, chandlerc.<br class="gmail_msg">
EricWF added a subscriber: cfe-commits.<br class="gmail_msg">
<br class="gmail_msg">
The title says it all.<br class="gmail_msg">
<br class="gmail_msg">
I just want to check that we agree on the general direction of this patch. Specifically that libc++ should be free to apply `no_discard` where we feel appropriate. If we agree then some other candidates are:<br class="gmail_msg">
<br class="gmail_msg">
- Containers `empty()` and `size()` methods.<br class="gmail_msg">
- `try_lock()` functions.<br class="gmail_msg">
- other `release()` functions.<br class="gmail_msg">
<br class="gmail_msg">
Additional suggestions welcome!<br class="gmail_msg"></blockquote><div><br></div><div>What sort of exceptions are there to a broader rule: all const member functions (I suppose there's a few that return discardable results as well as returning useful information via out parameters?)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="gmail_msg">
This patch fixes PR30898 (<a href="https://llvm.org/bugs/show_bug.cgi?id=30898" rel="noreferrer" class="gmail_msg" target="_blank">https://llvm.org/bugs/show_bug.cgi?id=30898</a>)<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D26596" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D26596</a><br class="gmail_msg">
<br class="gmail_msg">
Files:<br class="gmail_msg">
  include/__config<br class="gmail_msg">
  include/memory<br class="gmail_msg">
  test/libcxx/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.modifiers/release.fail.cpp<br class="gmail_msg">
  test/libcxx/utilities/memory/unique.ptr/unique.ptr.single/unique.ptr.single.modifiers/release.fail.cpp<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg">
</blockquote></div></div>