<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, Nov 3, 2016 at 10:52 AM Chandler Carruth via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chandlerc<br class="gmail_msg">
Date: Thu Nov  3 12:42:32 2016<br class="gmail_msg">
New Revision: 285946<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=285946&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=285946&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Using release to free memory is at best confusing -- one would expect<br class="gmail_msg">
that its result is in fact used. Instead, use reset.<br class="gmail_msg"></blockquote><div><br></div><div>Perhaps I'm missing something/perhaps you could provide some more context/detail: release() wouldn't've free'd memory, it would've leaked it, right? (seems more than just confusing, but actually wrong - so I'm confused by your description)<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="gmail_msg">
This was pointed out by PVS-Studio.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    cfe/trunk/lib/Frontend/VerifyDiagnosticConsumer.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: cfe/trunk/lib/Frontend/VerifyDiagnosticConsumer.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/VerifyDiagnosticConsumer.cpp?rev=285946&r1=285945&r2=285946&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/VerifyDiagnosticConsumer.cpp?rev=285946&r1=285945&r2=285946&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- cfe/trunk/lib/Frontend/VerifyDiagnosticConsumer.cpp (original)<br class="gmail_msg">
+++ cfe/trunk/lib/Frontend/VerifyDiagnosticConsumer.cpp Thu Nov  3 12:42:32 2016<br class="gmail_msg">
@@ -43,7 +43,7 @@ VerifyDiagnosticConsumer::~VerifyDiagnos<br class="gmail_msg">
   assert(!CurrentPreprocessor && "CurrentPreprocessor should be invalid!");<br class="gmail_msg">
   SrcManager = nullptr;<br class="gmail_msg">
   CheckDiagnostics();<br class="gmail_msg">
-  Diags.takeClient().release();<br class="gmail_msg">
+  Diags.takeClient().reset();<br class="gmail_msg">
 }<br class="gmail_msg">
<br class="gmail_msg">
 #ifndef NDEBUG<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg">
</blockquote></div></div>