<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Thu, Oct 27, 2016 at 6:02 AM Benjamin Kramer via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">bkramer accepted this revision.<br class="gmail_msg">
bkramer added a comment.<br class="gmail_msg">
This revision is now accepted and ready to land.<br class="gmail_msg">
<br class="gmail_msg">
This makes sense. While variable definitions in a header are weird, the warning that they're unused isn't adding any value.<br class="gmail_msg"></blockquote><div><br>I'm not sure that's true - the warning will then fire for users of the header that don't use the variable... <br><br>I'd like to know about the mistake ahead of time to avoid breaking my users.<br><br>(yes, certain headers could require their variables to be used - but that is a slightly niche requirement that could be addressed with a ((used)) attribute)<br><br>Also - does the same thing apply to static functions in headers?<br><br>- Dave<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D25990" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D25990</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
cfe-commits mailing list<br class="gmail_msg">
<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br class="gmail_msg">
</blockquote></div></div>