<div dir="ltr">Hi All,<div><br></div><div>This problem was caused by the definition of _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY.</div><div>The issue was fixed in r285531, which also adds linkage tests for std::strings destructor.</div><div><br></div><div>@Adtiya feel free to recommit this change.</div><div><br></div><div>/Eric</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 28, 2016 at 7:00 PM, Mehdi Amini via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Hi Adtiya,<div><br></div><div>I had to revert in r285485 to unbreak this build bot: <a href="http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_build/10737/" target="_blank">http://lab.llvm.org:8080/<wbr>green/job/clang-stage2-<wbr>configure-Rlto_build/10737/</a></div><div>(LTO bootstrap of clang).</div><div><br></div><div>Let’s iterate on the revision on Phabricator to figure out what it the right fix!</div><div><br></div><div>Best,</div><div><br></div><div>— </div><div>Mehdi</div><div><div class="h5"><div><br></div><div><br><div><blockquote type="cite"><div>On Oct 28, 2016, at 2:27 PM, Aditya Kumar via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:</div><br class="m_-1186659924287328528Apple-interchange-newline"><div><div>Author: hiraditya<br>Date: Fri Oct 28 16:27:24 2016<br>New Revision: 285456<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=285456&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=285456&view=rev</a><br>Log:<br>Added 'inline' attribute to basic_string's destructor<br><br>Author: laxmansole<br><br>Reviewers: howard.hinnant<br>           mclow.lists<br>Subscribers: EricWF, flyingforyou, evandro<br><br>Differential Revision: <a href="https://reviews.llvm.org/D25624" target="_blank">https://reviews.llvm.org/<wbr>D25624</a><br><br>Reapplying the patch as the bug <a href="https://llvm.org/bugs/show_bug.cgi?id=30341" target="_blank">https://llvm.org/bugs/show_<wbr>bug.cgi?id=30341</a> is fixed.<br><br>Currently basic_string's destructor is not getting inlined. So adding 'inline' attribute to ~basic_string().<br>Worked in collaboration with Aditya Kumar.<br><br>Modified:<br>    libcxx/trunk/include/string<br><br>Modified: libcxx/trunk/include/string<br>URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/string?rev=285456&r1=285455&r2=285456&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/include/<wbr>string?rev=285456&r1=285455&<wbr>r2=285456&view=diff</a><br>==============================<wbr>==============================<wbr>==================<br>--- libcxx/trunk/include/string (original)<br>+++ libcxx/trunk/include/string Fri Oct 28 16:27:24 2016<br>@@ -806,6 +806,7 @@ public:<br>     basic_string(initializer_<wbr>list<value_type> __il, const allocator_type& __a);<br> #endif  // _LIBCPP_HAS_NO_GENERALIZED_<wbr>INITIALIZERS<br><br>+    inline _LIBCPP_EXTERN_TEMPLATE_<wbr>INLINE_VISIBILITY<br>     ~basic_string();<br><br>     _LIBCPP_INLINE_VISIBILITY<br><br><br>______________________________<wbr>_________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br></div></div></blockquote></div><br></div></div></div></div><br>______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>