<div dir="ltr"><div>It appears you're testing fresh headers against a system installed libc++ library. Can you confirm this was your intention?<br></div><div><br></div><div>Either way I'll correct the test to handle this.</div><div><br></div><div>/Eric</div><div>Â </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 28, 2016 at 3:22 AM, Ismail Donmez <span dir="ltr"><<a href="mailto:ismail@i10z.com" target="_blank">ismail@i10z.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<span class=""><br>
On Fri, Oct 28, 2016 at 9:06 AM, Eric Fiselier via cfe-commits<br>
<<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br>
> Author: ericwf<br>
> Date: Fri Oct 28 01:06:50 2016<br>
> New Revision: 285382<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=285382&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=285382&view=rev</a><br>
> Log:<br>
> Add __libcpp_version file and __libcpp_library_version function.<br>
><br>
> This patch does two seperate things. First it adds a file called<br>
> "__libcpp_version" which only contains the current libc++ version<br>
> (currently 4000). This file is not intended for use as a header. This file<br>
> is used by Clang in order to easily determine the installed libc++ version.<br>
> This allows Clang to enable/disable certain language features only when the<br>
> library supports them.<br>
><br>
> The second change is the addition of _LIBCPP_LIBRARY_VERSION macro, which<br>
> returns the version of the installed dylib since it may be different than<br>
> the headers.<br>
<br>
</span>The test seems to be failing here:<br>
<br>
[ 7087s] ******************** TEST 'libc++ :: libcxx/version.pass.cpp'<br>
FAILED ********************<br>
[ 7087s] Compiled With:<br>
['/home/abuild/rpmbuild/BUILD/<wbr>llvm/stage1/bin/clang++', '-o',<br>
'/home/abuild/rpmbuild/BUILD/<wbr>llvm/stage2/projects/libcxx/<wbr>test/libcxx/Output/version.<wbr>pass.cpp.o',<br>
'-x', 'c++', '/home/abuild/rpmbuild/BUILD/<wbr>llvm/projects/libcxx/test/<wbr>libcxx/version.pass.cpp',<br>
'-c', '-v', '-Werror=thread-safety', '-std=c++1z', '-include',<br>
'/home/abuild/rpmbuild/BUILD/<wbr>llvm/projects/libcxx/test/<wbr>support/nasty_macros.hpp',<br>
'-nostdinc++', '-I/home/abuild/rpmbuild/<wbr>BUILD/llvm/projects/libcxx/<wbr>include',<br>
'-D__STDC_FORMAT_MACROS', '-D__STDC_LIMIT_MACROS',<br>
'-D__STDC_CONSTANT_MACROS',<br>
'-I/home/abuild/rpmbuild/<wbr>BUILD/llvm/projects/libcxx/<wbr>test/support',<br>
'-DLIBCXX_FILESYSTEM_STATIC_<wbr>TEST_ROOT="/home/abuild/<wbr>rpmbuild/BUILD/llvm/projects/<wbr>libcxx/test/std/experimental/<wbr>filesystem/Inputs/static_test_<wbr>env"',<br>
'-DLIBCXX_FILESYSTEM_DYNAMIC_<wbr>TEST_ROOT="/home/abuild/<wbr>rpmbuild/BUILD/llvm/stage2/<wbr>projects/libcxx/test/<wbr>filesystem/Output/dynamic_env"<wbr>',<br>
'-DLIBCXX_FILESYSTEM_DYNAMIC_<wbr>TEST_HELPER="/usr/bin/python2.<wbr>7<br>
/home/abuild/rpmbuild/BUILD/<wbr>llvm/projects/libcxx/test/<wbr>support/filesystem_dynamic_<wbr>test_helper.py"',<br>
'-c', '&&', '/home/abuild/rpmbuild/BUILD/<wbr>llvm/stage1/bin/clang++',<br>
'-o', '/home/abuild/rpmbuild/BUILD/<wbr>llvm/stage2/projects/libcxx/<wbr>test/libcxx/Output/version.<wbr>pass.cpp.exe',<br>
'/home/abuild/rpmbuild/BUILD/<wbr>llvm/stage2/projects/libcxx/<wbr>test/libcxx/Output/version.<wbr>pass.cpp.o',<br>
'-v', '-L/home/abuild/rpmbuild/<wbr>BUILD/llvm/stage2/lib64',<br>
'-Wl,-rpath,/home/abuild/<wbr>rpmbuild/BUILD/llvm/stage2/<wbr>lib64',<br>
'-nodefaultlibs', '-lc++experimental', '-lc++', '-lm', '-lgcc_s',<br>
'-lgcc', '-lpthread', '-lc', '-lgcc_s', '-lgcc']<br>
[ 7087s] Command: ['env',<br>
'LIBCXX_FILESYSTEM_DYNAMIC_<wbr>TEST_ROOT=/home/abuild/<wbr>rpmbuild/BUILD/llvm/stage2/<wbr>projects/libcxx/test/<wbr>filesystem/Output/dynamic_env'<wbr>,<br>
'/home/abuild/rpmbuild/BUILD/<wbr>llvm/stage2/projects/libcxx/<wbr>test/libcxx/Output/version.<wbr>pass.cpp.exe']<br>
[ 7087s] Exit Code: -6<br>
[ 7087s] Standard Error:<br>
[ 7087s] --<br>
[ 7087s] version.pass.cpp.exe:<br>
/home/abuild/rpmbuild/BUILD/<wbr>llvm/projects/libcxx/test/<wbr>libcxx/version.pass.cpp:26:<br>
int main(): Assertion `_LIBCPP_VERSION == _LIBCPP_LIBRARY_VERSION'<br>
failed.<br>
</blockquote></div><br></div>