<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">The test is validating pointer size as well, so it is failing on 32 bits right now.<div class=""><br class=""></div><div class="">I could try to differentiate some of the check and have them work on both size, but I can’t verify that the runtime works (I don’t have a 32 bits runtime).</div><div class=""><br class=""></div><div class="">— </div><div class="">Mehdi</div><div class=""><br class=""><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Oct 24, 2016, at 2:48 PM, Craig Topper <<a href="mailto:craig.topper@gmail.com" class="">craig.topper@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Doesn't this exclude 32-bit x86?</div><div class="gmail_extra"><br clear="all" class=""><div class=""><div class="gmail_signature" data-smartmail="gmail_signature">~Craig</div></div>
<br class=""><div class="gmail_quote">On Mon, Oct 24, 2016 at 2:22 PM, Mehdi Amini via cfe-commits <span dir="ltr" class=""><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank" class="">cfe-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: mehdi_amini<br class="">
Date: Mon Oct 24 16:22:01 2016<br class="">
New Revision: 285027<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=285027&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=285027&view=rev</a><br class="">
Log:<br class="">
Fix test on non-X86 platforms<br class="">
<br class="">
This is a fixup for r285019, adding an `#ifdef __x86_64__` since<br class="">
the os_log builtin is platform specific.<br class="">
<br class="">
Modified:<br class="">
cfe/trunk/test/CodeGen/<wbr class="">builtins.c<br class="">
<br class="">
Modified: cfe/trunk/test/CodeGen/<wbr class="">builtins.c<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/builtins.c?rev=285027&r1=285026&r2=285027&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/cfe/trunk/test/<wbr class="">CodeGen/builtins.c?rev=285027&<wbr class="">r1=285026&r2=285027&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- cfe/trunk/test/CodeGen/<wbr class="">builtins.c (original)<br class="">
+++ cfe/trunk/test/CodeGen/<wbr class="">builtins.c Mon Oct 24 16:22:01 2016<br class="">
@@ -369,6 +369,9 @@ long long test_builtin_readcyclecounter(<br class="">
return __builtin_readcyclecounter();<br class="">
}<br class="">
<br class="">
+// Behavior of __builtin_os_log differs between platforms, so only test on X86<br class="">
+#ifdef __x86_64__<br class="">
+<br class="">
// CHECK-LABEL: define void @test_builtin_os_log<br class="">
// CHECK: (i8* [[BUF:%.*]], i32 [[I:%.*]], i8* [[DATA:%.*]])<br class="">
void test_builtin_os_log(void *buf, int i, const char *data) {<br class="">
@@ -506,3 +509,5 @@ void test_builtin_os_log_percent(<wbr class="">void *b<br class="">
// CHECK: store i8* [[DATA2]], i8** [[ARG1_PTR]]<br class="">
__builtin_os_log_format(buf, "%s %%", data);<br class="">
}<br class="">
+<br class="">
+#endif<br class="">
\ No newline at end of file<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
cfe-commits mailing list<br class="">
<a href="mailto:cfe-commits@lists.llvm.org" class="">cfe-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/cfe-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></div></body></html>