<div dir="ltr">Looks like things are still unexpectedly passing at r284389 on macOS (but we currently only build and test libc++ on macOS, so maybe it's broken elsewhere too).<div><br></div><div><a href="https://codereview.chromium.org/2429533002/">https://codereview.chromium.org/2429533002/</a><br></div><div><a href="https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_upload_clang/builds/106/steps/package%20clang/logs/stdio">https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_upload_clang/builds/106/steps/package%20clang/logs/stdio</a><br></div><div><br></div><div><div>Unexpected Passing Tests (4):</div><div> libc++ :: std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t.pass.cpp</div><div> libc++ :: std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow.pass.cpp</div><div> libc++ :: std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t.pass.cpp</div><div> libc++ :: std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow.pass.cpp</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Oct 16, 2016 at 9:42 PM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">See the Mac bot here: <a href="https://codereview.chromium.org/2416293003/" target="_blank">https://codereview.<wbr>chromium.org/2416293003/</a> -> <a href="https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_upload_clang/builds/105/steps/package%20clang/logs/stdio" target="_blank">https://build.chromium.org/<wbr>p/tryserver.chromium.mac/<wbr>builders/mac_upload_clang/<wbr>builds/105/steps/package%<wbr>20clang/logs/stdio</a><div>I think that bot uses Xcode 8's compiler. I haven't tried again since 2 days ago.</div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Oct 15, 2016 at 4:08 PM, Eric Fiselier <span dir="ltr"><<a href="mailto:eric@efcs.ca" target="_blank">eric@efcs.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Nico,<div><br></div><div>Are these tests still broken for you? </div><span class="m_-4613936454663699989HOEnZb"><font color="#888888"><div><br></div><div>/Eric</div></font></span></div><div class="m_-4613936454663699989HOEnZb"><div class="m_-4613936454663699989h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 14, 2016 at 3:21 PM, Eric Fiselier <span dir="ltr"><<a href="mailto:eric@efcs.ca" target="_blank">eric@efcs.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Nico,<div><br></div><div>Could you give me more information about the compiler your using?</div><span class="m_-4613936454663699989m_-4087016906368001802HOEnZb"><font color="#888888"><div><br></div><div>/Eric</div></font></span></div><div class="m_-4613936454663699989m_-4087016906368001802HOEnZb"><div class="m_-4613936454663699989m_-4087016906368001802h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 14, 2016 at 1:21 PM, Nico Weber <span dir="ltr"><<a href="mailto:thakis@chromium.org" target="_blank">thakis@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This is breaking tests for me:<div><br></div><div><div>Unexpected Passing Tests (4):</div><div> libc++ :: std/language.support/support.d<wbr>ynamic/new.delete/new.delete.a<wbr>rray/new_align_val_t.pass.cpp</div><div> libc++ :: std/language.support/support.d<wbr>ynamic/new.delete/new.delete.a<wbr>rray/new_align_val_t_nothrow.p<wbr>ass.cpp</div><div> libc++ :: std/language.support/support.d<wbr>ynamic/new.delete/new.delete.s<wbr>ingle/new_align_val_t.pass.cpp</div><div> libc++ :: std/language.support/support.d<wbr>ynamic/new.delete/new.delete.s<wbr>ingle/new_align_val_t_nothrow.<wbr>pass.cpp</div></div><div><br></div><div>Am I holding something wrong, or are these XFAILs wrong?</div></div><div class="m_-4613936454663699989m_-4087016906368001802m_6822643031813970414HOEnZb"><div class="m_-4613936454663699989m_-4087016906368001802m_6822643031813970414h5"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 14, 2016 at 4:47 AM, Eric Fiselier via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ericwf<br>
Date: Fri Oct 14 03:47:09 2016<br>
New Revision: 284214<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=284214&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=284214&view=rev</a><br>
Log:<br>
XFAIL aligned allocation tests for older Clang versions<br>
<br>
Modified:<br>
libcxx/trunk/test/libcxx/test/<wbr>config.py<br>
libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t.pass.cpp<br>
libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t_nothrow.pass.cpp<br>
libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t_nothrow_replace.pass.<wbr>cpp<br>
libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t_replace.pass.cpp<br>
libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t.pass.cpp<br>
libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t_nothrow.pass.cpp<br>
libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t_nothrow_replace.pass<wbr>.cpp<br>
libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t_replace.pass.cpp<br>
<br>
Modified: libcxx/trunk/test/libcxx/test/<wbr>config.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/test/config.py?rev=284214&r1=284213&r2=284214&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/libcxx/trunk/test/libcxx<wbr>/test/config.py?rev=284214&r1=<wbr>284213&r2=284214&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/libcxx/test/<wbr>config.py (original)<br>
+++ libcxx/trunk/test/libcxx/test/<wbr>config.py Fri Oct 14 03:47:09 2016<br>
@@ -315,6 +315,10 @@ class Configuration(object):<br>
<br>
if self.cxx.hasCompileFlag('-fali<wbr>gned-allocation'):<br>
self.config.available_feature<wbr>s.add('-faligned-allocation')<br>
+ else:<br>
+ # FIXME remove this once more than just clang-4.0 support<br>
+ # C++17 aligned allocation.<br>
+ self.config.available_features<wbr>.add('no-aligned-allocation')<br>
<br>
if self.get_lit_bool('has_libatom<wbr>ic', False):<br>
self.config.available_feature<wbr>s.add('libatomic')<br>
<br>
Modified: libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t.pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t.pass.cpp?rev=284214&r1=284213&r2=284214&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/libcxx/trunk/test/std/la<wbr>nguage.support/support.dynamic<wbr>/new.delete/new.delete.array/n<wbr>ew_align_val_t.pass.cpp?rev=28<wbr>4214&r1=284213&r2=284214&view=<wbr>diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t.pass.cpp (original)<br>
+++ libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t.pass.cpp Fri Oct 14 03:47:09 2016<br>
@@ -9,11 +9,13 @@<br>
<br>
// UNSUPPORTED: c++98, c++03, c++11, c++14<br>
<br>
-// test operator new<br>
-<br>
// asan and msan will not call the new handler.<br>
// UNSUPPORTED: sanitizer-new-delete<br>
<br>
+// XFAIL: no-aligned-allocation<br>
+<br>
+// test operator new<br>
+<br>
#include <new><br>
#include <cstddef><br>
#include <cassert><br>
<br>
Modified: libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t_nothrow.pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow.pass.cpp?rev=284214&r1=284213&r2=284214&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/libcxx/trunk/test/std/la<wbr>nguage.support/support.dynamic<wbr>/new.delete/new.delete.array/n<wbr>ew_align_val_t_nothrow.pass.cp<wbr>p?rev=284214&r1=284213&r2=2842<wbr>14&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t_nothrow.pass.cpp (original)<br>
+++ libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t_nothrow.pass.cpp Fri Oct 14 03:47:09 2016<br>
@@ -9,11 +9,13 @@<br>
<br>
// UNSUPPORTED: c++98, c++03, c++11, c++14<br>
<br>
-// test operator new (nothrow)<br>
-<br>
// asan and msan will not call the new handler.<br>
// UNSUPPORTED: sanitizer-new-delete<br>
<br>
+// XFAIL: no-aligned-allocation<br>
+<br>
+// test operator new (nothrow)<br>
+<br>
#include <new><br>
#include <cstddef><br>
#include <cstdint><br>
<br>
Modified: libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t_nothrow_replace.pass.<wbr>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_nothrow_replace.pass.cpp?rev=284214&r1=284213&r2=284214&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/libcxx/trunk/test/std/la<wbr>nguage.support/support.dynamic<wbr>/new.delete/new.delete.array/n<wbr>ew_align_val_t_nothrow_replace<wbr>.pass.cpp?rev=284214&r1=284213<wbr>&r2=284214&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t_nothrow_replace.pass.<wbr>cpp (original)<br>
+++ libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t_nothrow_replace.pass.<wbr>cpp Fri Oct 14 03:47:09 2016<br>
@@ -8,10 +8,11 @@<br>
//===------------------------<wbr>------------------------------<wbr>----------------===//<br>
<br>
// UNSUPPORTED: c++98, c++03, c++11, c++14<br>
+// UNSUPPORTED: sanitizer-new-delete<br>
<br>
-// test operator new nothrow by replacing only operator new<br>
+// XFAIL: no-aligned-allocation<br>
<br>
-// UNSUPPORTED: sanitizer-new-delete<br>
+// test operator new nothrow by replacing only operator new<br>
<br>
#include <new><br>
#include <cstddef><br>
@@ -19,7 +20,6 @@<br>
#include <cassert><br>
#include <limits><br>
<br>
-<br>
constexpr auto OverAligned = alignof(std::max_align_t) * 2;<br>
<br>
int A_constructed = 0;<br>
<br>
Modified: libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t_replace.pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_align_val_t_replace.pass.cpp?rev=284214&r1=284213&r2=284214&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/libcxx/trunk/test/std/la<wbr>nguage.support/support.dynamic<wbr>/new.delete/new.delete.array/n<wbr>ew_align_val_t_replace.pass.cp<wbr>p?rev=284214&r1=284213&r2=2842<wbr>14&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t_replace.pass.cpp (original)<br>
+++ libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.array/new_ali<wbr>gn_val_t_replace.pass.cpp Fri Oct 14 03:47:09 2016<br>
@@ -8,10 +8,11 @@<br>
//===------------------------<wbr>------------------------------<wbr>----------------===//<br>
<br>
// UNSUPPORTED: c++98, c++03, c++11, c++14<br>
+// UNSUPPORTED: sanitizer-new-delete<br>
<br>
-// test operator new replacement<br>
+// XFAIL: no-aligned-allocation<br>
<br>
-// UNSUPPORTED: sanitizer-new-delete<br>
+// test operator new replacement<br>
<br>
#include <new><br>
#include <cstddef><br>
<br>
Modified: libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t.pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t.pass.cpp?rev=284214&r1=284213&r2=284214&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/libcxx/trunk/test/std/la<wbr>nguage.support/support.dynamic<wbr>/new.delete/new.delete.single/<wbr>new_align_val_t.pass.cpp?rev=2<wbr>84214&r1=284213&r2=284214&view<wbr>=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t.pass.cpp (original)<br>
+++ libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t.pass.cpp Fri Oct 14 03:47:09 2016<br>
@@ -9,11 +9,13 @@<br>
<br>
// UNSUPPORTED: c++98, c++03, c++11, c++14<br>
<br>
-// test operator new<br>
-<br>
// asan and msan will not call the new handler.<br>
// UNSUPPORTED: sanitizer-new-delete<br>
<br>
+// XFAIL: no-aligned-allocation<br>
+<br>
+// test operator new<br>
+<br>
#include <new><br>
#include <cstddef><br>
#include <cassert><br>
<br>
Modified: libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t_nothrow.pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow.pass.cpp?rev=284214&r1=284213&r2=284214&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/libcxx/trunk/test/std/la<wbr>nguage.support/support.dynamic<wbr>/new.delete/new.delete.single/<wbr>new_align_val_t_nothrow.pass.c<wbr>pp?rev=284214&r1=284213&r2=284<wbr>214&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t_nothrow.pass.cpp (original)<br>
+++ libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t_nothrow.pass.cpp Fri Oct 14 03:47:09 2016<br>
@@ -9,11 +9,13 @@<br>
<br>
// UNSUPPORTED: c++98, c++03, c++11, c++14<br>
<br>
-// test operator new (nothrow)<br>
-<br>
// asan and msan will not call the new handler.<br>
// UNSUPPORTED: sanitizer-new-delete<br>
<br>
+// XFAIL: no-aligned-allocation<br>
+<br>
+// test operator new (nothrow)<br>
+<br>
#include <new><br>
#include <cstddef><br>
#include <cstdint><br>
<br>
Modified: libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t_nothrow_replace.pass<wbr>.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_nothrow_replace.pass.cpp?rev=284214&r1=284213&r2=284214&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/libcxx/trunk/test/std/la<wbr>nguage.support/support.dynamic<wbr>/new.delete/new.delete.single/<wbr>new_align_val_t_nothrow_replac<wbr>e.pass.cpp?rev=284214&r1=28421<wbr>3&r2=284214&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t_nothrow_replace.pass<wbr>.cpp (original)<br>
+++ libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t_nothrow_replace.pass<wbr>.cpp Fri Oct 14 03:47:09 2016<br>
@@ -8,11 +8,11 @@<br>
//===------------------------<wbr>------------------------------<wbr>----------------===//<br>
<br>
// UNSUPPORTED: c++98, c++03, c++11, c++14<br>
-<br>
-// test operator new nothrow by replacing only operator new<br>
-<br>
// UNSUPPORTED: sanitizer-new-delete<br>
<br>
+// XFAIL: no-aligned-allocation<br>
+<br>
+// test operator new nothrow by replacing only operator new<br>
<br>
#include <new><br>
#include <cstddef><br>
<br>
Modified: libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t_replace.pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_align_val_t_replace.pass.cpp?rev=284214&r1=284213&r2=284214&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/libcxx/trunk/test/std/la<wbr>nguage.support/support.dynamic<wbr>/new.delete/new.delete.single/<wbr>new_align_val_t_replace.pass.c<wbr>pp?rev=284214&r1=284213&r2=284<wbr>214&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t_replace.pass.cpp (original)<br>
+++ libcxx/trunk/test/std/language<wbr>.support/support.dynamic/new.d<wbr>elete/new.delete.single/new_al<wbr>ign_val_t_replace.pass.cpp Fri Oct 14 03:47:09 2016<br>
@@ -8,10 +8,11 @@<br>
//===------------------------<wbr>------------------------------<wbr>----------------===//<br>
<br>
// UNSUPPORTED: c++98, c++03, c++11, c++14<br>
+// UNSUPPORTED: sanitizer-new-delete<br>
<br>
-// test operator new replacement<br>
+// XFAIL: no-aligned-allocation<br>
<br>
-// UNSUPPORTED: sanitizer-new-delete<br>
+// test operator new replacement<br>
<br>
#include <new><br>
#include <cstddef><br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>