<div dir="ltr">Thanks!<div><br></div><div>I still have that no-exception cleanup in my TODO list. Just pressed on time, hope to get to it soon.</div><div><br></div><div>/ Asiri</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 12, 2016 at 12:29 PM, Eric Fiselier via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ericwf<br>
Date: Wed Oct 12 06:29:18 2016<br>
New Revision: 284005<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=284005&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=284005&view=rev</a><br>
Log:<br>
Remove incorrect XFAILS<br>
<br>
Modified:<br>
    libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.assign/<wbr>copy.pass.cpp<br>
    libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.assign/<wbr>move.pass.cpp<br>
    libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.ctor/<wbr>copy.pass.cpp<br>
    libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.ctor/<wbr>move.pass.cpp<br>
<br>
Modified: libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.assign/<wbr>copy.pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/utilities/optional/optional.object/optional.object.assign/copy.pass.cpp?rev=284005&r1=284004&r2=284005&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/test/<wbr>libcxx/utilities/optional/<wbr>optional.object/optional.<wbr>object.assign/copy.pass.cpp?<wbr>rev=284005&r1=284004&r2=<wbr>284005&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.assign/<wbr>copy.pass.cpp (original)<br>
+++ libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.assign/<wbr>copy.pass.cpp Wed Oct 12 06:29:18 2016<br>
@@ -8,7 +8,6 @@<br>
 //===-------------------------<wbr>------------------------------<wbr>---------------===//<br>
<br>
 // UNSUPPORTED: c++98, c++03, c++11, c++14<br>
-// XFAIL: libcpp-no-exceptions<br>
 // <optional><br>
<br>
 // optional<T>& operator=(const optional<T>& rhs);<br>
@@ -45,7 +44,6 @@ struct Z2<br>
     Z2& operator=(const Z2&) = default;<br>
 };<br>
<br>
-#if __cplusplus >= 201402<br>
 template <class T><br>
 constexpr bool<br>
 test()<br>
@@ -55,23 +53,18 @@ test()<br>
     opt = opt2;<br>
     return true;<br>
 }<br>
-#endif<br>
<br>
 int main()<br>
 {<br>
     {<br>
         using T = int;<br>
         static_assert((std::is_<wbr>trivially_copy_assignable<<wbr>optional<T>>::value), "");<br>
-#if __cplusplus >= 201402<br>
         static_assert(test<T>(), "");<br>
-#endif<br>
     }<br>
     {<br>
         using T = X;<br>
         static_assert((std::is_<wbr>trivially_copy_assignable<<wbr>optional<T>>::value), "");<br>
-#if __cplusplus >= 201402<br>
         static_assert(test<T>(), "");<br>
-#endif<br>
     }<br>
     static_assert(!(std::is_<wbr>trivially_copy_assignable<<wbr>optional<Y>>::value), "");<br>
     static_assert(!(std::is_<wbr>trivially_copy_assignable<<wbr>optional<std::string>>::value)<wbr>, "");<br>
<br>
Modified: libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.assign/<wbr>move.pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/utilities/optional/optional.object/optional.object.assign/move.pass.cpp?rev=284005&r1=284004&r2=284005&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/test/<wbr>libcxx/utilities/optional/<wbr>optional.object/optional.<wbr>object.assign/move.pass.cpp?<wbr>rev=284005&r1=284004&r2=<wbr>284005&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.assign/<wbr>move.pass.cpp (original)<br>
+++ libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.assign/<wbr>move.pass.cpp Wed Oct 12 06:29:18 2016<br>
@@ -8,7 +8,6 @@<br>
 //===-------------------------<wbr>------------------------------<wbr>---------------===//<br>
<br>
 // UNSUPPORTED: c++98, c++03, c++11, c++14<br>
-// XFAIL: libcpp-no-exceptions<br>
 // <optional><br>
<br>
 // optional<T>& operator=(optional<T>&& rhs);<br>
@@ -42,7 +41,6 @@ struct Z2<br>
     Z2& operator=(Z2&&) = default;<br>
 };<br>
<br>
-#if __cplusplus >= 201402<br>
 template <class T><br>
 constexpr bool<br>
 test()<br>
@@ -52,23 +50,18 @@ test()<br>
     opt = std::move(opt2);<br>
     return true;<br>
 }<br>
-#endif<br>
<br>
 int main()<br>
 {<br>
     {<br>
         using T = int;<br>
         static_assert((std::is_<wbr>trivially_copy_constructible<<wbr>optional<T>>::value), "");<br>
-#if __cplusplus >= 201402<br>
         static_assert(test<T>(), "");<br>
-#endif<br>
     }<br>
     {<br>
         using T = X;<br>
         static_assert((std::is_<wbr>trivially_copy_constructible<<wbr>optional<T>>::value), "");<br>
-#if __cplusplus >= 201402<br>
         static_assert(test<T>(), "");<br>
-#endif<br>
     }<br>
     static_assert(!(std::is_<wbr>trivially_move_assignable<<wbr>optional<Y>>::value), "");<br>
     static_assert(!(std::is_<wbr>trivially_move_assignable<<wbr>optional<std::string>>::value)<wbr>, "");<br>
<br>
Modified: libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.ctor/<wbr>copy.pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/utilities/optional/optional.object/optional.object.ctor/copy.pass.cpp?rev=284005&r1=284004&r2=284005&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/test/<wbr>libcxx/utilities/optional/<wbr>optional.object/optional.<wbr>object.ctor/copy.pass.cpp?rev=<wbr>284005&r1=284004&r2=284005&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.ctor/<wbr>copy.pass.cpp (original)<br>
+++ libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.ctor/<wbr>copy.pass.cpp Wed Oct 12 06:29:18 2016<br>
@@ -8,7 +8,7 @@<br>
 //===-------------------------<wbr>------------------------------<wbr>---------------===//<br>
<br>
 // UNSUPPORTED: c++98, c++03, c++11, c++14<br>
-// XFAIL: libcpp-no-exceptions<br>
+<br>
 // <optional><br>
<br>
 // optional(const optional<T>& rhs);<br>
<br>
Modified: libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.ctor/<wbr>move.pass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/utilities/optional/optional.object/optional.object.ctor/move.pass.cpp?rev=284005&r1=284004&r2=284005&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/libcxx/trunk/test/<wbr>libcxx/utilities/optional/<wbr>optional.object/optional.<wbr>object.ctor/move.pass.cpp?rev=<wbr>284005&r1=284004&r2=284005&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.ctor/<wbr>move.pass.cpp (original)<br>
+++ libcxx/trunk/test/libcxx/<wbr>utilities/optional/optional.<wbr>object/optional.object.ctor/<wbr>move.pass.cpp Wed Oct 12 06:29:18 2016<br>
@@ -8,7 +8,7 @@<br>
 //===-------------------------<wbr>------------------------------<wbr>---------------===//<br>
<br>
 // UNSUPPORTED: c++98, c++03, c++11, c++14<br>
-// XFAIL: libcpp-no-exceptions<br>
+<br>
 // <optional><br>
<br>
 // optional(optional<T>&& rhs);<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>