<div dir="ltr">More love for no-exceptions in any case ;)<br><br>Cheers!</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 12, 2016 at 12:52 PM, Eric Fiselier <span dir="ltr"><<a href="mailto:eric@efcs.ca" target="_blank">eric@efcs.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I just committed those tests, so I kinda had to fix them :-P</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 12, 2016 at 5:40 AM, Asiri Rathnayake <span dir="ltr"><<a href="mailto:asiri.rathnayake@gmail.com" target="_blank">asiri.rathnayake@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks!<div><br></div><div>I still have that no-exception cleanup in my TODO list. Just pressed on time, hope to get to it soon.</div><span class="m_-2034668432721742228HOEnZb"><font color="#888888"><div><br></div><div>/ Asiri</div></font></span></div><div class="m_-2034668432721742228HOEnZb"><div class="m_-2034668432721742228h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 12, 2016 at 12:29 PM, Eric Fiselier via cfe-commits <span dir="ltr"><<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ericwf<br>
Date: Wed Oct 12 06:29:18 2016<br>
New Revision: 284005<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=284005&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=284005&view=rev</a><br>
Log:<br>
Remove incorrect XFAILS<br>
<br>
Modified:<br>
libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.assign/<a href="http://copy.pa">copy.pa</a><wbr>ss.cpp<br>
libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.assign/<a href="http://move.pa">move.pa</a><wbr>ss.cpp<br>
libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.ctor/copy.pass<wbr>.cpp<br>
libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.ctor/move.pass<wbr>.cpp<br>
<br>
Modified: libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.assign/<a href="http://copy.pa">copy.pa</a><wbr>ss.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/utilities/optional/optional.object/optional.object.assign/copy.pass.cpp?rev=284005&r1=284004&r2=284005&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/libcxx/trunk/test/libcxx<wbr>/utilities/optional/optional.o<wbr>bject/optional.object.assign/c<wbr>opy.pass.cpp?rev=284005&r1=284<wbr>004&r2=284005&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.assign/<a href="http://copy.pa">copy.pa</a><wbr>ss.cpp (original)<br>
+++ libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.assign/<a href="http://copy.pa">copy.pa</a><wbr>ss.cpp Wed Oct 12 06:29:18 2016<br>
@@ -8,7 +8,6 @@<br>
//===------------------------<wbr>------------------------------<wbr>----------------===//<br>
<br>
// UNSUPPORTED: c++98, c++03, c++11, c++14<br>
-// XFAIL: libcpp-no-exceptions<br>
// <optional><br>
<br>
// optional<T>& operator=(const optional<T>& rhs);<br>
@@ -45,7 +44,6 @@ struct Z2<br>
Z2& operator=(const Z2&) = default;<br>
};<br>
<br>
-#if __cplusplus >= 201402<br>
template <class T><br>
constexpr bool<br>
test()<br>
@@ -55,23 +53,18 @@ test()<br>
opt = opt2;<br>
return true;<br>
}<br>
-#endif<br>
<br>
int main()<br>
{<br>
{<br>
using T = int;<br>
static_assert((std::is_trivia<wbr>lly_copy_assignable<optional<T<wbr>>>::value), "");<br>
-#if __cplusplus >= 201402<br>
static_assert(test<T>(), "");<br>
-#endif<br>
}<br>
{<br>
using T = X;<br>
static_assert((std::is_trivia<wbr>lly_copy_assignable<optional<T<wbr>>>::value), "");<br>
-#if __cplusplus >= 201402<br>
static_assert(test<T>(), "");<br>
-#endif<br>
}<br>
static_assert(!(std::is_trivi<wbr>ally_copy_assignable<optional<<wbr>Y>>::value), "");<br>
static_assert(!(std::is_trivi<wbr>ally_copy_assignable<optional<<wbr>std::string>>::value), "");<br>
<br>
Modified: libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.assign/<a href="http://move.pa">move.pa</a><wbr>ss.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/utilities/optional/optional.object/optional.object.assign/move.pass.cpp?rev=284005&r1=284004&r2=284005&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/libcxx/trunk/test/libcxx<wbr>/utilities/optional/optional.o<wbr>bject/optional.object.assign/m<wbr>ove.pass.cpp?rev=284005&r1=284<wbr>004&r2=284005&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.assign/<a href="http://move.pa">move.pa</a><wbr>ss.cpp (original)<br>
+++ libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.assign/<a href="http://move.pa">move.pa</a><wbr>ss.cpp Wed Oct 12 06:29:18 2016<br>
@@ -8,7 +8,6 @@<br>
//===------------------------<wbr>------------------------------<wbr>----------------===//<br>
<br>
// UNSUPPORTED: c++98, c++03, c++11, c++14<br>
-// XFAIL: libcpp-no-exceptions<br>
// <optional><br>
<br>
// optional<T>& operator=(optional<T>&& rhs);<br>
@@ -42,7 +41,6 @@ struct Z2<br>
Z2& operator=(Z2&&) = default;<br>
};<br>
<br>
-#if __cplusplus >= 201402<br>
template <class T><br>
constexpr bool<br>
test()<br>
@@ -52,23 +50,18 @@ test()<br>
opt = std::move(opt2);<br>
return true;<br>
}<br>
-#endif<br>
<br>
int main()<br>
{<br>
{<br>
using T = int;<br>
static_assert((std::is_trivia<wbr>lly_copy_constructible<optiona<wbr>l<T>>::value), "");<br>
-#if __cplusplus >= 201402<br>
static_assert(test<T>(), "");<br>
-#endif<br>
}<br>
{<br>
using T = X;<br>
static_assert((std::is_trivia<wbr>lly_copy_constructible<optiona<wbr>l<T>>::value), "");<br>
-#if __cplusplus >= 201402<br>
static_assert(test<T>(), "");<br>
-#endif<br>
}<br>
static_assert(!(std::is_trivi<wbr>ally_move_assignable<optional<<wbr>Y>>::value), "");<br>
static_assert(!(std::is_trivi<wbr>ally_move_assignable<optional<<wbr>std::string>>::value), "");<br>
<br>
Modified: libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.ctor/copy.pass<wbr>.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/utilities/optional/optional.object/optional.object.ctor/copy.pass.cpp?rev=284005&r1=284004&r2=284005&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/libcxx/trunk/test/libcxx<wbr>/utilities/optional/optional.o<wbr>bject/optional.object.ctor/cop<wbr>y.pass.cpp?rev=284005&r1=28400<wbr>4&r2=284005&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.ctor/copy.pass<wbr>.cpp (original)<br>
+++ libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.ctor/copy.pass<wbr>.cpp Wed Oct 12 06:29:18 2016<br>
@@ -8,7 +8,7 @@<br>
//===------------------------<wbr>------------------------------<wbr>----------------===//<br>
<br>
// UNSUPPORTED: c++98, c++03, c++11, c++14<br>
-// XFAIL: libcpp-no-exceptions<br>
+<br>
// <optional><br>
<br>
// optional(const optional<T>& rhs);<br>
<br>
Modified: libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.ctor/move.pass<wbr>.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/utilities/optional/optional.object/optional.object.ctor/move.pass.cpp?rev=284005&r1=284004&r2=284005&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/libcxx/trunk/test/libcxx<wbr>/utilities/optional/optional.o<wbr>bject/optional.object.ctor/mov<wbr>e.pass.cpp?rev=284005&r1=28400<wbr>4&r2=284005&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.ctor/move.pass<wbr>.cpp (original)<br>
+++ libcxx/trunk/test/libcxx/utili<wbr>ties/optional/optional.object/<wbr>optional.object.ctor/move.pass<wbr>.cpp Wed Oct 12 06:29:18 2016<br>
@@ -8,7 +8,7 @@<br>
//===------------------------<wbr>------------------------------<wbr>----------------===//<br>
<br>
// UNSUPPORTED: c++98, c++03, c++11, c++14<br>
-// XFAIL: libcpp-no-exceptions<br>
+<br>
// <optional><br>
<br>
// optional(optional<T>&& rhs);<br>
<br>
<br>
______________________________<wbr>_________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>