<div dir="ltr"><div>You should not need to account for any nsw/nuw flags if the clang test does not enable the optimizer.<br></div><div>Ie, D24955 should not be running at -O0.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 5, 2016 at 1:09 PM, Nemanja Ivanovic <span dir="ltr"><<a href="mailto:nemanja.i.ibm@gmail.com" target="_blank">nemanja.i.ibm@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>OK, I get testing that I'm fine with if I remove the -O2 and the checks for 'select i1'.<br><br></div>Does that change suffice for the purposes of <a href="https://reviews.llvm.org/D24955" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2495<wbr>5</a>?<br><br></div>Namely, do I need to account for the possible addition of nsw/nuw flags to the add instructions even without -O2?<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 5, 2016 at 8:24 PM, Sanjay Patel <span dir="ltr"><<a href="mailto:spatel@rotateright.com" target="_blank">spatel@rotateright.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">spatel added a comment.<br>
<span><br>
In <a href="https://reviews.llvm.org/D24397#562469" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2439<wbr>7#562469</a>, @bjope wrote:<br>
<br>
> (I'm still hesitating about commiting <a href="https://reviews.llvm.org/D24955" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2495<wbr>5</a> in llvm since that would make these clang tests fail...)<br>
<br>
<br>
</span>You can't do that. Bots will send you fail mail all day as they choke on the clang tests - speaking from experience. :)<br>
We either need to fix or revert this commit in order to let <a href="https://reviews.llvm.org/D24955" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2495<wbr>5</a> proceed.<br>
<div><div><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D24397" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2439<wbr>7</a><br>
<br>
<br>
<br>
</div></div></blockquote></div><br></div>
</blockquote></div><br></div>