<div dir="ltr"><div>This warning group (-Wshift-op-parentheses) is already a subgroup of -Wparentheses. The suggestion of moving to a sub group was to create a new subgroup, either as a child of -Wshift-op-parentheses or -Wparentheses, so that this new warning can be turned on and off independently and allow it to be off by default.<br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 3, 2016 at 3:26 AM, Daniel Marjamäki <span dir="ltr"><<a href="mailto:Daniel.Marjamaki@evidente.se" target="_blank">Daniel.Marjamaki@evidente.se</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello!<br>
<br>
Moving it to a subgroup such as -Wparentheses is fine for me. I will look at that when I have time. Do you think this warning has an acceptable output then?<br>
<br>
Best regards,<br>
Daniel Marjamäki<br>
<br>
..............................<wbr>..............................<wbr>..............................<wbr>........................<br>
Daniel Marjamäki Senior Engineer<br>
Evidente ES East AB Warfvinges väg 34 SE-112 51 Stockholm Sweden<br>
<br>
Mobile: <a href="tel:%2B46%20%280%29709%2012%2042%2062" value="+46709124262" target="_blank">+46 (0)709 12 42 62</a><br>
E-mail: <a href="mailto:Daniel.Marjamaki@evidente.se" target="_blank">Daniel.Marjamaki@evidente.se</a><br>
<br>
<a href="http://www.evidente.se" rel="noreferrer" target="_blank">www.evidente.se</a><br>
<br>
______________________________<wbr>__________<br>
Från: Richard Trieu [<a href="mailto:rtrieu@google.com" target="_blank">rtrieu@google.com</a>]<br>
Skickat: den 1 oktober 2016 00:41<br>
Till: <a href="mailto:reviews%2BD24861%2Bpublic%2B1ab88c6ac93f51fd@reviews.llvm.org" target="_blank">reviews+D24861+public+1ab88c6a<wbr>c93f51fd@reviews.llvm.org</a><br>
Kopia: Daniel Marjamäki; David Blaikie; <a href="mailto:joerg@netbsd.org" target="_blank">joerg@netbsd.org</a>; <a href="mailto:bruno.cardoso@gmail.com" target="_blank">bruno.cardoso@gmail.com</a>; cfe-commits<br>
Ämne: Re: [PATCH] D24861: [Sema] extend Wshift-op-parentheses so it warns for multiplicative operators<br>
<span class="m_-2025265434069076328im m_-2025265434069076328HOEnZb"><br>
Currently, this warning is on by default. As you said, the results you found look intentional in many cases, so there is a high false positive rate. For on by default warnings, we expect a high true positive rate and intend for users to not disable the warning. From my analysis on a separate codebase, I found less than 10% true positive rate out of 200 warnings. One option might be to move this warning to a subgroup, which would leave it discoverable from either -Wall or -Wparentheses, but not have it on by default.<br>
<br>
</span><div class="m_-2025265434069076328HOEnZb"><div class="m_-2025265434069076328h5">On Wed, Sep 28, 2016 at 4:09 AM, Daniel Marjamäki <<a href="mailto:daniel.marjamaki@evidente.se" target="_blank">daniel.marjamaki@evidente.se</a><<wbr>mailto:<a href="mailto:daniel.marjamaki@evidente.se" target="_blank">daniel.marjamaki@eviden<wbr>te.se</a>>> wrote:<br>
danielmarjamaki added a comment.<br>
<br>
I updated the patch so it does not warn about 'A * B << C'. It's a simple fix. I have not made careful measurements but I guess that the performance penalty is acceptable.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D24861" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2486<wbr>1</a><br>
<br>
<br>
<br>
<br>
</div></div></blockquote></div><br></div></div></div>