<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 29, 2016, at 11:04 PM, Eric Liu <<a href="mailto:ioeric@google.com" class="">ioeric@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I've switched the default email format to be plain text only now. This option should be per-user configurable, but somehow it is not shown in the "Settings"; I'll try if I can make the option personalized.<div class=""><br class=""></div><div class="">Regarding new features and bug fixes in this upgrade, I don't really have a list since the Phabricator we are running is the open-source repo + some local modification. The last merge was more than one year ago, so I guess there should be a long list of new features and bug fixes.</div><div class=""><br class=""></div><div class="">Some new features that I am aware of:</div><div class="">- Syntax highlighting.</div><div class="">- Patch size in email headers</div><div class="">- HTML email (disabled)</div><div class="">- More compatible with modern arc (the reason for this upgrade)</div><div class="">- and more to be discovered! :)</div><div class=""><br class=""></div><div class="">@Mehdi Deleting unposted inline comments works for me. At which patch did this issue occur?</div></div></div></blockquote><div><br class=""></div><div>I picked randomly in the “All revisions” list.</div><div>(For example: <a href="https://reviews.llvm.org/D25094" class="">https://reviews.llvm.org/D25094</a> )</div><div><br class=""></div><div>It seems I can delete comment unless I edited it first. Strange…</div><div><br class=""></div><div>— </div><div>Mehdi</div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class="">- Eric<br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Sep 30, 2016 at 7:39 AM Mehdi Amini <<a href="mailto:mehdi.amini@apple.com" class="">mehdi.amini@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="gmail_msg">One of the new “feature” is that emails are HTML only right now. Not quite nice for the archive (or for interacting by email). <div class="gmail_msg">See for instance: <a href="http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160926/172081.html" class="gmail_msg" target="_blank">http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160926/172081.html</a></div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">(Also the funky "[Changed Subscribers] “ in the title)</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Another issue is that we can’t delete unposted inline comment anymore.</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">— </div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg">Mehdi</div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg">On Sep 29, 2016, at 9:35 PM, Zachary Turner via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="gmail_msg m_-7299065993437751147Apple-interchange-newline"><div class="gmail_msg"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="gmail_msg">You mentioned this was for an upgrade. Are there any major new features or bugfixes to be aware of?</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><div class="gmail_quote gmail_msg" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div dir="ltr" class="gmail_msg">On Thu, Sep 29, 2016 at 9:26 PM Eric Liu via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Hi all,<div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Phabricator is (finally) back online! Let me know if you have any feedback or problem :)</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Thanks,</div><div class="gmail_msg">Eric</div></div><div dir="ltr" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Thu, Sep 29, 2016 at 10:23 PM Eric Liu <<a href="mailto:ioeric@google.com" class="gmail_msg" target="_blank">ioeric@google.com</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_msg">According to top and iotop, mysqld is still working, and the progress bar did move by a little bit, so I think it's just really slow. Apologies if this is blocking you.<br class="gmail_msg"></div></div><div dir="ltr" class="gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Thu, Sep 29, 2016 at 10:17 PM Zachary Turner via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Still no word on when it will be back up? It's not hung is it? :D</div><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Thu, Sep 29, 2016 at 9:03 AM mats petersson via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg">On 29 September 2016 at 16:11, Mehdi Amini via llvm-dev<span class="gmail_msg m_-7299065993437751147Apple-converted-space"> </span><span dir="ltr" class="gmail_msg"><<a href="mailto:llvm-dev@lists.llvm.org" class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a>></span><span class="gmail_msg m_-7299065993437751147Apple-converted-space"> </span>wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="gmail_msg" style="word-wrap:break-word"><br class="gmail_msg"><div class="gmail_msg"><span class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg">On Sep 29, 2016, at 7:21 AM, Eric Liu via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="gmail_msg"><div class="gmail_msg"><div dir="ltr" class="gmail_msg">Sorry for blocking everyone for so long.</div></div></blockquote><div class="gmail_msg"><br class="gmail_msg"></div></span>No pb, thanks very much for taking care of it :)<span class="gmail_msg"><br class="gmail_msg"><br class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg"><div dir="ltr" class="gmail_msg"><div class="gmail_msg">It has been more than a year since the last upgrade, and mysql is adjusting schema for a table with ~150G data on a single VM instance.</div></div></div></blockquote><div class="gmail_msg"><br class="gmail_msg"></div></span><div class="gmail_msg">150GB? I’m very surprised there is so much data in our phab! That seems huge...</div></div></div></blockquote><div class="gmail_msg"><br class="gmail_msg"></div></div></div></div><div dir="ltr" class="gmail_msg"><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg"><div class="gmail_msg">My guess is that this includes all the diffs for every revision of every review (as well as all the comments, etc), and it probably isn't as clever with diffs as for example git. Which quite soon adds up to huge numbers when you have tens of thousands of reviews.<br class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Purse speculation of course, I have never looked inside phabricator (or for that matter, any other code-review tool).<br class="gmail_msg"></div><div class="gmail_msg"><br class="gmail_msg">--<br class="gmail_msg"></div><div class="gmail_msg">Mats<br class="gmail_msg"></div></div></div></div><div dir="ltr" class="gmail_msg"><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="gmail_msg" style="word-wrap:break-word"><div class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">— </div><div class="gmail_msg">Mehdi</div><div class="gmail_msg"><div class="gmail_msg m_-7299065993437751147m_7169125674557700348m_3092591631962722308m_-9106871089354926186m_671308778382563185h5"><br class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg"><div dir="ltr" class="gmail_msg"><div class="gmail_msg">Sadly, the progress bar isn't giving useful information (plus I am not a good system admin), so I couldn't tell the ETA...</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">FYI: According to previous maintainer, it takes a couple of hours for the last upgrade, so this should be done within a few hours (hopefully!).</div></div><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Thu, Sep 29, 2016 at 4:04 PM Krzysztof Parzyszek via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Is there any ETA?<br class="gmail_msg"><br class="gmail_msg">-Krzysztof<br class="gmail_msg"><br class="gmail_msg">On 9/29/2016 5:34 AM, Eric Liu via llvm-dev wrote:<br class="gmail_msg">> That was a bad estimation. Database upgrade is taking time.<br class="gmail_msg">><br class="gmail_msg">> On Thu, Sep 29, 2016 at 11:03 AM Eric Liu <<a href="mailto:ioeric@google.com" class="gmail_msg" target="_blank">ioeric@google.com</a><br class="gmail_msg">> <mailto:<a href="mailto:ioeric@google.com" class="gmail_msg" target="_blank">ioeric@google.com</a>>> wrote:<br class="gmail_msg">><br class="gmail_msg">> Hi all,<br class="gmail_msg">><br class="gmail_msg">> Phabricator(<a href="http://reviews.llvm.org/" rel="noreferrer" class="gmail_msg" target="_blank">reviews.llvm.org</a><span class="gmail_msg m_-7299065993437751147Apple-converted-space"> </span><<a href="http://reviews.llvm.org/" rel="noreferrer" class="gmail_msg" target="_blank">http://reviews.llvm.org</a>>) will be down<br class="gmail_msg">> for ~30 mins for an upgrade. Sorry for the short notice.<br class="gmail_msg">><br class="gmail_msg">> Regards,<br class="gmail_msg">> Eric<br class="gmail_msg">><br class="gmail_msg">><br class="gmail_msg">><br class="gmail_msg">> _______________________________________________<br class="gmail_msg">> LLVM Developers mailing list<br class="gmail_msg">><span class="gmail_msg m_-7299065993437751147Apple-converted-space"> </span><a href="mailto:llvm-dev@lists.llvm.org" class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a><br class="gmail_msg">><span class="gmail_msg m_-7299065993437751147Apple-converted-space"> </span><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="gmail_msg">><br class="gmail_msg"><br class="gmail_msg">--<br class="gmail_msg">Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,<br class="gmail_msg">hosted by The Linux Foundation<br class="gmail_msg">_______________________________________________<br class="gmail_msg">LLVM Developers mailing list<br class="gmail_msg"><a href="mailto:llvm-dev@lists.llvm.org" class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a><br class="gmail_msg"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="gmail_msg"></blockquote></div>_______________________________________________<br class="gmail_msg">LLVM Developers mailing list<br class="gmail_msg"><a href="mailto:llvm-dev@lists.llvm.org" class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a><br class="gmail_msg"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="gmail_msg"></div></blockquote></div></div></div><br class="gmail_msg"></div><br class="gmail_msg">_______________________________________________<br class="gmail_msg">LLVM Developers mailing list<br class="gmail_msg"><a href="mailto:llvm-dev@lists.llvm.org" class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a><br class="gmail_msg"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="gmail_msg"><br class="gmail_msg"></blockquote></div></div></div>_______________________________________________<br class="gmail_msg">LLVM Developers mailing list<br class="gmail_msg"><a href="mailto:llvm-dev@lists.llvm.org" class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a><br class="gmail_msg"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="gmail_msg"></blockquote></div>_______________________________________________<br class="gmail_msg">LLVM Developers mailing list<br class="gmail_msg"><a href="mailto:llvm-dev@lists.llvm.org" class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a><br class="gmail_msg"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class="gmail_msg"></blockquote></div></div></blockquote></div></div></div><div dir="ltr" class="gmail_msg"></div>_______________________________________________<br class="gmail_msg">llvm-commits mailing list<br class="gmail_msg"><a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg"></blockquote></div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="gmail_msg">_______________________________________________</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="gmail_msg">LLVM Developers mailing list</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><a href="mailto:llvm-dev@lists.llvm.org" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg" target="_blank">llvm-dev@lists.llvm.org</a><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a></div></blockquote></div><br class="gmail_msg"></div></div></blockquote></div></div></div>
</div></blockquote></div><br class=""></body></html>