<div dir="ltr">On Tue, Sep 13, 2016 at 11:06 AM, Justin Bogner <span dir="ltr"><<a href="mailto:mail@justinbogner.com" target="_blank">mail@justinbogner.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5">Saleem Abdulrasool via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> writes:<br>
> Author: compnerd<br>
> Date: Mon Sep 12 16:15:23 2016<br>
> New Revision: 281261<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=281261&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=281261&view=rev</a><br>
> Log:<br>
> CodeGen: use some range-based for loops<br>
><br>
> Use range-based for loops to simplify the logic.  Add an explicit check for<br>
> MachO as the inline asm uses MachO specific directives.<br>
><br>
> Modified:<br>
>     cfe/trunk/lib/CodeGen/<wbr>CGObjCMac.cpp<br>
><br>
> Modified: cfe/trunk/lib/CodeGen/<wbr>CGObjCMac.cpp<br>
> URL:<br>
> <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGObjCMac.cpp?rev=281261&r1=281260&r2=281261&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/cfe/trunk/lib/CodeGen/<wbr>CGObjCMac.cpp?rev=281261&r1=<wbr>281260&r2=281261&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- cfe/trunk/lib/CodeGen/<wbr>CGObjCMac.cpp (original)<br>
> +++ cfe/trunk/lib/CodeGen/<wbr>CGObjCMac.cpp Mon Sep 12 16:15:23 2016<br>
> @@ -5178,27 +5178,23 @@ void CGObjCMac::FinishModule() {<br>
>    // important for correct linker interaction.<br>
>    //<br>
>    // FIXME: It would be nice if we had an LLVM construct for this.<br>
> -  if (!LazySymbols.empty() || !DefinedSymbols.empty()) {<br>
> +  if ((!LazySymbols.empty() || !DefinedSymbols.empty()) &&<br>
> +      CGM.getTriple().<wbr>isOSBinFormatMachO()) {<br>
>      SmallString<256> Asm;<br>
>      Asm += CGM.getModule().<wbr>getModuleInlineAsm();<br>
>      if (!Asm.empty() && Asm.back() != '\n')<br>
>        Asm += '\n';<br>
><br>
>      llvm::raw_svector_ostream OS(Asm);<br>
> -    for (llvm::SetVector<<wbr>IdentifierInfo*>::iterator I = DefinedSymbols.begin(),<br>
> -           e = DefinedSymbols.end(); I != e; ++I)<br>
> -      OS << "\t.objc_class_name_" << (*I)->getName() << "=0\n"<br>
> -         << "\t.globl .objc_class_name_" << (*I)->getName() << "\n";<br>
> -    for (llvm::SetVector<<wbr>IdentifierInfo*>::iterator I = LazySymbols.begin(),<br>
> -         e = LazySymbols.end(); I != e; ++I) {<br>
> -      OS << "\t.lazy_reference .objc_class_name_" << (*I)->getName() << "\n";<br>
> -    }<br>
> +    for (const auto &Sym : DefinedSymbols)<br>
<br>
</div></div>Is this a reference to a pointer? Please write this as `const auto *`,<br>
or even just write out the type `const IdentifierInfo *`.</blockquote><div><br></div><div>Sorry for the delay: SVN r281730.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5">
> +      OS << "\t.objc_class_name_" << Sym->getName() << "=0\n"<br>
> +         << "\t.globl .objc_class_name_" << Sym->getName() << "\n";<br>
> +    for (const auto &Sym : LazySymbols)<br>
> +      OS << "\t.lazy_reference .objc_class_name_" << Sym->getName() << "\n";<br>
> +    for (const auto &Category : DefinedCategoryNames)<br>
> +      OS << "\t.objc_category_name_" << Category << "=0\n"<br>
> +         << "\t.globl .objc_category_name_" << Category << "\n";<br>
><br>
> -    for (size_t i = 0, e = DefinedCategoryNames.size(); i < e; ++i) {<br>
> -      OS << "\t.objc_category_name_" << DefinedCategoryNames[i] << "=0\n"<br>
> -         << "\t.globl .objc_category_name_" << DefinedCategoryNames[i] << "\n";<br>
> -    }<br>
> -<br>
>      CGM.getModule().<wbr>setModuleInlineAsm(OS.str());<br>
>    }<br>
>  }<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</div></div>