<div dir="ltr">Strange. FWIW you can dump all the variables that are present in your environment. You need to go to Tools -> Options -> Projects and Solutions -> Build and Run and choose either Normal, Detailed, or Diagnostic for the MSBuild project build output verbosity. Then in the output window you will get a ton of spam, some of which is the set of all MSBuild variables you can take advantage of.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Sep 15, 2016 at 4:25 PM Hans Wennborg <<a href="mailto:hans@chromium.org">hans@chromium.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">When I first opened the solution in VS it prompted me to install it and I did.<br class="gmail_msg">
<br class="gmail_msg">
On Thu, Sep 15, 2016 at 4:17 PM, Zachary Turner <<a href="mailto:zturner@google.com" class="gmail_msg" target="_blank">zturner@google.com</a>> wrote:<br class="gmail_msg">
> You may need to install the Visual Studio SDK. Did you do that when you<br class="gmail_msg">
> initially installed VS 2015?<br class="gmail_msg">
><br class="gmail_msg">
> On Thu, Sep 15, 2016 at 4:15 PM Hans Wennborg <<a href="mailto:hans@chromium.org" class="gmail_msg" target="_blank">hans@chromium.org</a>> wrote:<br class="gmail_msg">
>><br class="gmail_msg">
>> Well, on my machine $(SDKToolsDir) doesn't work :-( I suspect the file<br class="gmail_msg">
>> will need manual tweaking by whoever is trying to build the plugin.<br class="gmail_msg">
>><br class="gmail_msg">
>> Anyway, I've updated the solution to build with VS2015 in r281648 and<br class="gmail_msg">
>> confirmed that it can still be used with older VS versions too.<br class="gmail_msg">
>><br class="gmail_msg">
>> Cheers,<br class="gmail_msg">
>> Hans<br class="gmail_msg">
>><br class="gmail_msg">
>> On Thu, Aug 18, 2016 at 7:11 PM, Zachary Turner <<a href="mailto:zturner@google.com" class="gmail_msg" target="_blank">zturner@google.com</a>><br class="gmail_msg">
>> wrote:<br class="gmail_msg">
>> > The key.snk is generated when you build, the problem is the csproj file<br class="gmail_msg">
>> > hardcodes the directory to the sdk instead of using the appropriate<br class="gmail_msg">
>> > project<br class="gmail_msg">
>> > system variable like $(SDKToolsDir)<br class="gmail_msg">
>> ><br class="gmail_msg">
>> > On Thu, Aug 18, 2016 at 7:09 PM Zachary Turner <<a href="mailto:zturner@google.com" class="gmail_msg" target="_blank">zturner@google.com</a>><br class="gmail_msg">
>> > wrote:<br class="gmail_msg">
>> >><br class="gmail_msg">
>> >> Llvm doesn't support vs2012 anymore, as long as it supports vs2013 it's<br class="gmail_msg">
>> >> fine<br class="gmail_msg">
>> >> On Thu, Aug 18, 2016 at 7:07 PM Antonio Maiorano <<a href="mailto:amaiorano@gmail.com" class="gmail_msg" target="_blank">amaiorano@gmail.com</a>><br class="gmail_msg">
>> >> wrote:<br class="gmail_msg">
>> >>><br class="gmail_msg">
>> >>> Hi,<br class="gmail_msg">
>> >>><br class="gmail_msg">
>> >>> What I meant by upgrade was simply making it build in VS 2015.<br class="gmail_msg">
>> >>> However,<br class="gmail_msg">
>> >>> you bring up a valid point about making sure the extension will<br class="gmail_msg">
>> >>> continue to<br class="gmail_msg">
>> >>> work in VS 2012. I will look into that. Like those references that go<br class="gmail_msg">
>> >>> from<br class="gmail_msg">
>> >>> 10 to 14 that point out; I wonder if instead I should be able to bring<br class="gmail_msg">
>> >>> in<br class="gmail_msg">
>> >>> those version 10 assemblies via NuGet. I'll take a closer look.<br class="gmail_msg">
>> >>><br class="gmail_msg">
>> >>> Part of my change, however, seems to imply that the extension (vsix)<br class="gmail_msg">
>> >>> project would not build correctly even in VS 2012. For instance, the<br class="gmail_msg">
>> >>> missing<br class="gmail_msg">
>> >>> Key.snk file. I don't have VS 2012 installed at the moment, so I<br class="gmail_msg">
>> >>> cannot<br class="gmail_msg">
>> >>> validate.<br class="gmail_msg">
>> >>><br class="gmail_msg">
>> >>> Thanks,<br class="gmail_msg">
>> >>><br class="gmail_msg">
>> >>> Antonio<br class="gmail_msg">
>> >>><br class="gmail_msg">
>> >>><br class="gmail_msg">
>> >>><br class="gmail_msg">
>> >>> On Thu, 18 Aug 2016 at 19:38 Hans Wennborg <<a href="mailto:hans@chromium.org" class="gmail_msg" target="_blank">hans@chromium.org</a>> wrote:<br class="gmail_msg">
>> >>>><br class="gmail_msg">
>> >>>> Hi Antonio,<br class="gmail_msg">
>> >>>><br class="gmail_msg">
>> >>>> On Wed, Aug 17, 2016 at 8:15 AM, Antonio Maiorano via cfe-commits<br class="gmail_msg">
>> >>>> <<a href="mailto:cfe-commits@lists.llvm.org" class="gmail_msg" target="_blank">cfe-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg">
>> >>>> > This patch for clang-format-vs includes the following:<br class="gmail_msg">
>> >>>> ><br class="gmail_msg">
>> >>>> > - Upgrade to VS 2015, including .NET framework upgrade from 4.0 to<br class="gmail_msg">
>> >>>> > 4.5, and<br class="gmail_msg">
>> >>>> > upgrading Microsoft.VisualStudio references to v14 versions<br class="gmail_msg">
>> >>>> > - Fix build by removing dependency on "Key.snk" file which was<br class="gmail_msg">
>> >>>> > never<br class="gmail_msg">
>> >>>> > checked<br class="gmail_msg">
>> >>>> > in (and not really required anyway)<br class="gmail_msg">
>> >>>> > - Add ".vs" directory to svn ignore (new folder that VS 2015<br class="gmail_msg">
>> >>>> > creates<br class="gmail_msg">
>> >>>> > for<br class="gmail_msg">
>> >>>> > user settings)<br class="gmail_msg">
>> >>>><br class="gmail_msg">
>> >>>> "What does "Upgrade to VS 2015 mean? Adding support for running the<br class="gmail_msg">
>> >>>> plugin in VS2015, or does it mean requiring VS2015 for building?<br class="gmail_msg">
>> >>>><br class="gmail_msg">
>> >>>> +zturner: I thought the plugin already worked in VS 2015?<br class="gmail_msg">
>> >>>><br class="gmail_msg">
>> >>>> I mostly just build the plugin without knowing exactly how this stuff<br class="gmail_msg">
>> >>>> works, but looking at the patch I'm worried that you're increasing<br class="gmail_msg">
>> >>>> the<br class="gmail_msg">
>> >>>> required version for building it? I see a bunch of values going from<br class="gmail_msg">
>> >>>> 10 (VS 2012) to 14 (VS 2015).<br class="gmail_msg">
>> >>>><br class="gmail_msg">
>> >>>> Thanks,<br class="gmail_msg">
>> >>>> Hans<br class="gmail_msg">
</blockquote></div>